projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
88d8822
)
ALSA: pcm: disallow linking stream to itself
author
Michał Mirosław
<mirq-linux@rere.qmqm.pl>
Mon, 8 Jun 2020 16:50:39 +0000
(18:50 +0200)
committer
Takashi Iwai
<tiwai@suse.de>
Mon, 8 Jun 2020 17:35:29 +0000
(19:35 +0200)
Prevent SNDRV_PCM_IOCTL_LINK linking stream to itself - the code
can't handle it. Fixed commit is not where bug was introduced, but
changes the context significantly.
Cc: stable@vger.kernel.org
Fixes: 0888c321de70 ("pcm_native: switch to fdget()/fdput()")
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Link:
https://lore.kernel.org/r/89c4a2487609a0ed6af3ecf01cc972bdc59a7a2d.1591634956.git.mirq-linux@rere.qmqm.pl
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/pcm_native.c
patch
|
blob
|
history
diff --git
a/sound/core/pcm_native.c
b/sound/core/pcm_native.c
index c08732998a4250bc3b9071a9a3d760d6dd918253..eeab8850ed76c5bca3859672375c2a60b17e8e3b 100644
(file)
--- a/
sound/core/pcm_native.c
+++ b/
sound/core/pcm_native.c
@@
-2176,6
+2176,12
@@
static int snd_pcm_link(struct snd_pcm_substream *substream, int fd)
}
pcm_file = f.file->private_data;
substream1 = pcm_file->substream;
+
+ if (substream == substream1) {
+ res = -EINVAL;
+ goto _badf;
+ }
+
group = kzalloc(sizeof(*group), GFP_KERNEL);
if (!group) {
res = -ENOMEM;