RDMA/irdma: Do not modify to SQD on error
authorMustafa Ismail <mustafa.ismail@intel.com>
Tue, 14 Nov 2023 17:02:45 +0000 (11:02 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Dec 2023 17:45:12 +0000 (18:45 +0100)
[ Upstream commit ba12ab66aa83a2340a51ad6e74b284269745138c ]

Remove the modify to SQD before going to ERROR state. It is not needed.

Fixes: b48c24c2d710 ("RDMA/irdma: Implement device supported verb APIs")
Signed-off-by: Mustafa Ismail <mustafa.ismail@intel.com>
Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
Link: https://lore.kernel.org/r/20231114170246.238-2-shiraz.saleem@intel.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/infiniband/hw/irdma/verbs.c

index 3eb7a7a..895799c 100644 (file)
@@ -1424,13 +1424,6 @@ int irdma_modify_qp_roce(struct ib_qp *ibqp, struct ib_qp_attr *attr,
                case IB_QPS_SQE:
                case IB_QPS_ERR:
                case IB_QPS_RESET:
-                       if (iwqp->iwarp_state == IRDMA_QP_STATE_RTS) {
-                               spin_unlock_irqrestore(&iwqp->lock, flags);
-                               info.next_iwarp_state = IRDMA_QP_STATE_SQD;
-                               irdma_hw_modify_qp(iwdev, iwqp, &info, true);
-                               spin_lock_irqsave(&iwqp->lock, flags);
-                       }
-
                        if (iwqp->iwarp_state == IRDMA_QP_STATE_ERROR) {
                                spin_unlock_irqrestore(&iwqp->lock, flags);
                                if (udata && udata->inlen) {