isdn: mISDN: netjet: Remove redundant pci_clear_master
authorCai Huoqing <cai.huoqing@linux.dev>
Thu, 23 Mar 2023 11:59:11 +0000 (19:59 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 24 Mar 2023 09:13:42 +0000 (09:13 +0000)
Remove pci_clear_master to simplify the code,
the bus-mastering is also cleared in do_pci_disable_device,
like this:
./drivers/pci/pci.c:2197
static void do_pci_disable_device(struct pci_dev *dev)
{
u16 pci_command;

pci_read_config_word(dev, PCI_COMMAND, &pci_command);
if (pci_command & PCI_COMMAND_MASTER) {
pci_command &= ~PCI_COMMAND_MASTER;
pci_write_config_word(dev, PCI_COMMAND, pci_command);
}

pcibios_disable_device(dev);
}.
And dev->is_busmaster is set to 0 in pci_disable_device.

Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/hardware/mISDN/netjet.c

index f8447135a90220bf24eef9403d13f725035ef43a..566c790a9481df2082c93c11ac2d19a044531550 100644 (file)
@@ -970,7 +970,6 @@ nj_release(struct tiger_hw *card)
        write_lock_irqsave(&card_lock, flags);
        list_del(&card->list);
        write_unlock_irqrestore(&card_lock, flags);
-       pci_clear_master(card->pdev);
        pci_disable_device(card->pdev);
        pci_set_drvdata(card->pdev, NULL);
        kfree(card);