ath9k: Use platform_get_irq() to get the interrupt
authorMinghao Chi <chi.minghao@zte.com.cn>
Mon, 14 Mar 2022 06:45:01 +0000 (06:45 +0000)
committerKalle Valo <quic_kvalo@quicinc.com>
Fri, 18 Mar 2022 15:37:56 +0000 (17:37 +0200)
It is not recommened to use platform_get_resource(pdev, IORESOURCE_IRQ)
for requesting IRQ's resources any more, as they can be not ready yet in
case of DT-booting.

platform_get_irq() instead is a recommended way for getting IRQ even if
it was not retrieved earlier.

It also makes code simpler because we're getting "int" value right away
and no conversion from resource to int is required.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20220314064501.2114002-1-chi.minghao@zte.com.cn
drivers/net/wireless/ath/ath9k/ahb.c

index cdefb8e..c9b853a 100644 (file)
@@ -98,14 +98,12 @@ static int ath_ahb_probe(struct platform_device *pdev)
                return -ENOMEM;
        }
 
-       res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-       if (res == NULL) {
+       irq = platform_get_irq(pdev, 0);
+       if (irq < 0) {
                dev_err(&pdev->dev, "no IRQ resource found\n");
-               return -ENXIO;
+               return irq;
        }
 
-       irq = res->start;
-
        ath9k_fill_chanctx_ops();
        hw = ieee80211_alloc_hw(sizeof(struct ath_softc), &ath9k_ops);
        if (hw == NULL) {