perf annotate: Stop using map->groups, use map_symbol->mg instead
authorArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 4 Nov 2019 19:52:19 +0000 (16:52 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 12 Nov 2019 11:20:53 +0000 (08:20 -0300)
These were the last uses of map->groups, next cset will nuke it.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lkml.kernel.org/n/tip-n3g0foos7l7uxq9nar0zo0vj@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/arch/s390/annotate/instructions.c
tools/perf/ui/browsers/annotate.c
tools/perf/util/annotate.c

index bdd7ab3..2a6662e 100644 (file)
@@ -38,7 +38,7 @@ static int s390_call__parse(struct arch *arch, struct ins_operands *ops,
                return -1;
        target.addr = map__objdump_2mem(map, ops->target.addr);
 
-       if (map_groups__find_ams(map->groups, &target) == 0 &&
+       if (map_groups__find_ams(ms->mg, &target) == 0 &&
            map__rip_2objdump(target.ms.map, map->map_ip(target.ms.map, target.addr)) == ops->target.addr)
                ops->target.sym = target.ms.sym;
 
index ad1fe5b..992705c 100644 (file)
@@ -430,6 +430,7 @@ static bool annotate_browser__callq(struct annotate_browser *browser,
                return true;
        }
 
+       target_ms.mg  = ms->mg;
        target_ms.map = ms->map;
        target_ms.sym = dl->ops.target.sym;
        pthread_mutex_unlock(&notes->lock);
index e0a9e9e..5ea9a45 100644 (file)
@@ -271,7 +271,7 @@ static int call__parse(struct arch *arch, struct ins_operands *ops, struct map_s
 find_target:
        target.addr = map__objdump_2mem(map, ops->target.addr);
 
-       if (map_groups__find_ams(map->groups, &target) == 0 &&
+       if (map_groups__find_ams(ms->mg, &target) == 0 &&
            map__rip_2objdump(target.ms.map, map->map_ip(target.ms.map, target.addr)) == ops->target.addr)
                ops->target.sym = target.ms.sym;
 
@@ -391,7 +391,7 @@ static int jump__parse(struct arch *arch, struct ins_operands *ops, struct map_s
         * Actual navigation will come next, with further understanding of how
         * the symbol searching and disassembly should be done.
         */
-       if (map_groups__find_ams(map->groups, &target) == 0 &&
+       if (map_groups__find_ams(ms->mg, &target) == 0 &&
            map__rip_2objdump(target.ms.map, map->map_ip(target.ms.map, target.addr)) == ops->target.addr)
                ops->target.sym = target.ms.sym;
 
@@ -1545,7 +1545,7 @@ static int symbol__parse_objdump_line(struct symbol *sym,
                        .ms = { .map = map, },
                };
 
-               if (!map_groups__find_ams(map->groups, &target) &&
+               if (!map_groups__find_ams(args->ms.mg, &target) &&
                    target.ms.sym->start == target.al_addr)
                        dl->ops.target.sym = target.ms.sym;
        }