cameracalibrate: Improve gst-inspect documentation
authorVivia Nikolaidou <vivia@ahiru.eu>
Tue, 13 Oct 2020 10:11:06 +0000 (13:11 +0300)
committerVivia Nikolaidou <vivia@ahiru.eu>
Tue, 13 Oct 2020 14:21:59 +0000 (17:21 +0300)
Thanks to @kazz_naka on Twitter

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1691>

docs/plugins/gst_plugins_cache.json
ext/opencv/gstcameracalibrate.cpp

index c848461..75ae26a 100644 (file)
         "elements": {
             "cameracalibrate": {
                 "author": "Philippe Renon <philippe_renon@yahoo.fr>",
-                "description": "Performs camera calibration",
+                "description": "Performs camera calibration by having it point at a chessboard pattern using upstream/downstream cameraundistort",
                 "hierarchy": [
                     "GstCameraCalibrate",
                     "GstOpencvVideoFilter",
                         "writable": true
                     },
                     "board-height": {
-                        "blurb": "The board height in number of items",
+                        "blurb": "The board height in number of items (e.g. number of squares for chessboard)",
                         "conditionally-available": false,
                         "construct": false,
                         "construct-only": false,
                         "writable": true
                     },
                     "board-width": {
-                        "blurb": "The board width in number of items",
+                        "blurb": "The board width in number of items (e.g. number of squares for chessboard)",
                         "conditionally-available": false,
                         "construct": false,
                         "construct-only": false,
index 16f8e30..291f6c7 100644 (file)
@@ -204,13 +204,13 @@ gst_camera_calibrate_class_init (GstCameraCalibrateClass * klass)
 
   g_object_class_install_property (gobject_class, PROP_BOARD_WIDTH,
       g_param_spec_int ("board-width", "Board Width",
-          "The board width in number of items",
+          "The board width in number of items (e.g. number of squares for chessboard)",
           1, G_MAXINT, DEFAULT_BOARD_WIDTH,
           (GParamFlags) (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)));
 
   g_object_class_install_property (gobject_class, PROP_BOARD_HEIGHT,
       g_param_spec_int ("board-height", "Board Height",
-          "The board height in number of items",
+          "The board height in number of items (e.g. number of squares for chessboard)",
           1, G_MAXINT, DEFAULT_BOARD_WIDTH,
           (GParamFlags) (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)));
 
@@ -276,7 +276,8 @@ gst_camera_calibrate_class_init (GstCameraCalibrateClass * klass)
   gst_element_class_set_static_metadata (element_class,
       "cameracalibrate",
       "Filter/Effect/Video",
-      "Performs camera calibration",
+      "Performs camera calibration by having it point at a chessboard pattern "
+      "using upstream/downstream cameraundistort",
       "Philippe Renon <philippe_renon@yahoo.fr>");
 
   /* add sink and source pad templates */