ARM: dts: samsung: s5pv210: fix camera unit addresses/ranges
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sat, 22 Jul 2023 12:17:19 +0000 (14:17 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 5 Feb 2024 20:14:19 +0000 (20:14 +0000)
[ Upstream commit 07e6a553c2f1d385edfc9185081dee442a9dd38d ]

The camera node has both unit address and children within the same bus
mapping, thus needs proper ranges property to fix dtc W=1 warnings:

  Warning (unit_address_vs_reg): /soc/camera@fa600000: node has a unit name, but no reg or ranges property
  Warning (simple_bus_reg): /soc/camera@fa600000: missing or empty reg/ranges property

Subtract 0xfa600000 from all its children nodes.  No functional impact
expected.

Link: https://lore.kernel.org/r/20230722121719.150094-3-krzysztof.kozlowski@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm/boot/dts/samsung/s5pv210.dtsi

index f7de5b5..ed560c9 100644 (file)
 
                camera: camera@fa600000 {
                        compatible = "samsung,fimc";
+                       ranges = <0x0 0xfa600000 0xe01000>;
                        clocks = <&clocks SCLK_CAM0>, <&clocks SCLK_CAM1>;
                        clock-names = "sclk_cam0", "sclk_cam1";
                        #address-cells = <1>;
                        #size-cells = <1>;
                        #clock-cells = <1>;
                        clock-output-names = "cam_a_clkout", "cam_b_clkout";
-                       ranges;
 
-                       csis0: csis@fa600000 {
+                       csis0: csis@0 {
                                compatible = "samsung,s5pv210-csis";
-                               reg = <0xfa600000 0x4000>;
+                               reg = <0x00000000 0x4000>;
                                interrupt-parent = <&vic2>;
                                interrupts = <29>;
                                clocks = <&clocks CLK_CSIS>,
                                #size-cells = <0>;
                        };
 
-                       fimc0: fimc@fb200000 {
+                       fimc0: fimc@c00000 {
                                compatible = "samsung,s5pv210-fimc";
-                               reg = <0xfb200000 0x1000>;
+                               reg = <0x00c00000 0x1000>;
                                interrupts = <5>;
                                interrupt-parent = <&vic2>;
                                clocks = <&clocks CLK_FIMC0>,
                                samsung,cam-if;
                        };
 
-                       fimc1: fimc@fb300000 {
+                       fimc1: fimc@d00000 {
                                compatible = "samsung,s5pv210-fimc";
-                               reg = <0xfb300000 0x1000>;
+                               reg = <0x00d00000 0x1000>;
                                interrupt-parent = <&vic2>;
                                interrupts = <6>;
                                clocks = <&clocks CLK_FIMC1>,
                                samsung,lcd-wb;
                        };
 
-                       fimc2: fimc@fb400000 {
+                       fimc2: fimc@e00000 {
                                compatible = "samsung,s5pv210-fimc";
-                               reg = <0xfb400000 0x1000>;
+                               reg = <0x00e00000 0x1000>;
                                interrupt-parent = <&vic2>;
                                interrupts = <7>;
                                clocks = <&clocks CLK_FIMC2>,