sched: Remove WARN_ON(!sd) from init_sched_groups_power()
authorViresh Kumar <viresh.kumar@linaro.org>
Tue, 11 Jun 2013 11:02:45 +0000 (16:32 +0530)
committerIngo Molnar <mingo@kernel.org>
Wed, 19 Jun 2013 10:58:47 +0000 (12:58 +0200)
sd can't be NULL in init_sched_groups_power() and so checking it for NULL isn't
useful. In case it is required, then also we need to rearrange the code a bit as
we already accessed invalid pointer sd to get sg: sg = sd->groups.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/2bbe633cd74b431c05253a8ce61fdfd5066a531b.1370948150.git.viresh.kumar@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/core.c

index 014c97f..21b1403 100644 (file)
@@ -5400,7 +5400,7 @@ static void init_sched_groups_power(int cpu, struct sched_domain *sd)
 {
        struct sched_group *sg = sd->groups;
 
-       WARN_ON(!sd || !sg);
+       WARN_ON(!sg);
 
        do {
                sg->group_weight = cpumask_weight(sched_group_cpus(sg));