ASoC: amd: acp3x-rt5682-max9836: Configure jack as not detecting Line Out
authorAlper Nebi Yasak <alpernebiyasak@gmail.com>
Sat, 5 Aug 2023 16:22:16 +0000 (19:22 +0300)
committerMark Brown <broonie@kernel.org>
Tue, 8 Aug 2023 12:59:24 +0000 (13:59 +0100)
The RT5682, RT1015 and RT1015p codecs used in this driver do not seem
capable of distinguishing Line Out connections from Headphone, but
the driver configures its jack object as if it can. Remove the wrong
value from the jack creation call to avoid any confusion.

Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Tested-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Link: https://lore.kernel.org/r/20230805162216.441410-1-alpernebiyasak@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/acp3x-rt5682-max9836.c

index 3bf7e1e..28ad5f5 100644 (file)
@@ -98,7 +98,7 @@ static int acp3x_5682_init(struct snd_soc_pcm_runtime *rtd)
        rt5682_dai_bclk = clk_get(component->dev, "rt5682-dai-bclk");
 
        ret = snd_soc_card_jack_new_pins(card, "Headset Jack",
-                                        SND_JACK_HEADSET | SND_JACK_LINEOUT |
+                                        SND_JACK_HEADSET |
                                         SND_JACK_BTN_0 | SND_JACK_BTN_1 |
                                         SND_JACK_BTN_2 | SND_JACK_BTN_3,
                                         &pco_jack,