webrtc/nice: Make sure to return NULL when validating turn server fails

It affects 'add-turn-server' signal action and 'turn-server' property
of webrtcbin.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3120>

diff --git a/subprojects/gst-plugins-bad/gst-libs/gst/webrtc/nice/nice.c b/subprojects/gst-plugins-bad/gst-libs/gst/webrtc/nice/nice.c
index d2ba844..379e133 100644 (file)
--- a/subprojects/gst-plugins-bad/gst-libs/gst/webrtc/nice/nice.c
+++ b/subprojects/gst-plugins-bad/gst-libs/gst/webrtc/nice/nice.c
@@ -1344,12 +1344,19 @@ _validate_turn_server (GstWebRTCNice * ice, const gchar * s)
     }
   }
 
-out:
   g_list_free (keys);
   g_free (user);
   g_free (pass);
 
   return uri;
+
+out:
+  g_list_free (keys);
+  g_free (user);
+  g_free (pass);
+  gst_uri_unref (uri);
+
+  return NULL;
 }
 
 static void