Fix error check for fread

Change-Id: I6f9bffd6ce2ab70dd61fa98ce9bb5ac0d95bc206
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>

diff --git a/src/vc_elm.c b/src/vc_elm.c
index f8b6752..45cc206 100644 (file)
--- a/src/vc_elm.c
+++ b/src/vc_elm.c
@@ -124,15 +124,15 @@ static int __check_privilege(const char* uid, const char * privilege)
        char smack_label[1024] = "/proc/self/attr/current";
 
        if (!p_cynara) {
-           return false;
+               return false;
        }
 
        fp = fopen(smack_label, "r");
        if (fp != NULL) {
-           if (fread(smack_label, 1, sizeof(smack_label), fp) <= 0)
-               VC_ELM_LOG_ERR("[ERROR] fail to fread");
+               if (sizeof(smack_label) != fread(smack_label, 1, sizeof(smack_label), fp))
+                       VC_ELM_LOG_ERR("[ERROR] fail to fread");
 
-           fclose(fp);
+               fclose(fp);
        }
 
        pid_t pid = getpid();
@@ -140,10 +140,10 @@ static int __check_privilege(const char* uid, const char * privilege)
        int ret = cynara_check(p_cynara, smack_label, session, uid, privilege);
        VC_ELM_LOG_DBG("[Client]cynara_check returned %d(%s)", ret, (CYNARA_API_ACCESS_ALLOWED == ret) ? "Allowed" : "Denied");
        if (session)
-           free(session);
+               free(session);
 
        if (ret != CYNARA_API_ACCESS_ALLOWED)
-           return false;
+               return false;
        return true;
 }