Avoid unnecessary preview format setting

[Version] 0.2.36
[Profile] Common
[Issue Type] Update
[Dependency module] N/A
[Test] [M(T) - Boot=(OK), sdb=(OK), Home=(OK), Touch=(OK), Version=tizen-3.0-mobile_20170302.1]

Change-Id: I1d651ef043669a648a036c97e21f2c3120d9fdf1
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>

diff --git a/legacy/src/legacy_recorder.c b/legacy/src/legacy_recorder.c
index 2243a03..405e8e0 100644 (file)
--- a/legacy/src/legacy_recorder.c
+++ b/legacy/src/legacy_recorder.c
@@ -584,9 +584,8 @@ int legacy_recorder_create_videorecorder(camera_h camera, recorder_h *recorder)
        legacy_recorder_get_state((recorder_h)handle, (recorder_state_e*)&handle->state);
 
        mm_camcorder_get_attributes(handle->mm_handle, NULL,
-               MMCAM_CAMERA_FORMAT, &preview_format,
+               MMCAM_CAMERA_FORMAT, &handle->origin_preview_format,
                NULL);
-       handle->origin_preview_format = preview_format;
 
        mm_camcorder_get_attributes(handle->mm_handle, NULL,
                MMCAM_RECOMMEND_PREVIEW_FORMAT_FOR_RECORDING, &preview_format,
@@ -615,13 +614,16 @@ int legacy_recorder_create_videorecorder(camera_h camera, recorder_h *recorder)
        _camera_set_use(camera, true);
        legacy_camera_lock(camera, false);
 
-       if (handle->state == RECORDER_STATE_CREATED) {
+       if (handle->state == RECORDER_STATE_CREATED &&
+               preview_format != handle->origin_preview_format) {
                ret = mm_camcorder_set_attributes(handle->mm_handle, NULL,
                        MMCAM_CAMERA_FORMAT, preview_format,
                        NULL);
+
                if (ret == MM_ERROR_NONE)
                        handle->changed_preview_format = preview_format;
        }
+
        *recorder = (recorder_h)handle;
 
        return RECORDER_ERROR_NONE;
@@ -745,7 +747,9 @@ int legacy_recorder_destroy(recorder_h recorder)
                        NULL);
 
                /* preview format was changed? */
-               if (ret == MM_ERROR_NONE && preview_format == handle->changed_preview_format) {
+               if (ret == MM_ERROR_NONE &&
+                       preview_format == handle->changed_preview_format &&
+                       preview_format != handle->origin_preview_format) {
                        ret = mm_camcorder_set_attributes(handle->mm_handle, NULL,
                                MMCAM_CAMERA_FORMAT, handle->origin_preview_format,
                                NULL);

diff --git a/packaging/mmsvc-recorder.spec b/packaging/mmsvc-recorder.spec
index 5058a01..73a18b7 100644 (file)
--- a/packaging/mmsvc-recorder.spec
+++ b/packaging/mmsvc-recorder.spec
@@ -1,6 +1,6 @@
 Name:       mmsvc-recorder
 Summary:    A Recorder module for muse server
-Version:    0.2.35
+Version:    0.2.36
 Release:    0
 Group:      Multimedia/Libraries
 License:    Apache-2.0