projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
c2abcf3
)
of: base: Fix phandle argument length mismatch error message
author
Baruch Siach
<baruch@tkos.co.il>
Thu, 30 Dec 2021 16:31:52 +0000
(18:31 +0200)
committer
Rob Herring
<robh@kernel.org>
Sat, 8 Jan 2022 14:46:59 +0000
(08:46 -0600)
The cell_count field of of_phandle_iterator is the number of cells we
expect in the phandle arguments list when cells_name is missing. The
error message should show the number of cells we actually see.
Fixes:
af3be70a3211
("of: Improve of_phandle_iterator_next() error message")
Cc: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Rob Herring <robh@kernel.org>
Link:
https://lore.kernel.org/r/96519ac55be90a63fa44afe01480c30d08535465.1640881913.git.baruch@tkos.co.il
drivers/of/base.c
patch
|
blob
|
history
diff --git
a/drivers/of/base.c
b/drivers/of/base.c
index
5b90760
..
81c8909
100644
(file)
--- a/
drivers/of/base.c
+++ b/
drivers/of/base.c
@@
-1376,9
+1376,9
@@
int of_phandle_iterator_next(struct of_phandle_iterator *it)
* property data length
*/
if (it->cur + count > it->list_end) {
- pr_err("%pOF: %s = %d found %d\n",
+ pr_err("%pOF: %s = %d found %
t
d\n",
it->parent, it->cells_name,
- count, it->
cell_count
);
+ count, it->
list_end - it->cur
);
goto err;
}
}