drivers: Remove useless trailing comments from mmiowb() invocations
authorWill Deacon <will.deacon@arm.com>
Fri, 22 Feb 2019 16:56:31 +0000 (16:56 +0000)
committerWill Deacon <will.deacon@arm.com>
Mon, 8 Apr 2019 11:00:56 +0000 (12:00 +0100)
In preparation for using coccinelle to remove all mmiowb() instances
from drivers, remove all trailing comments since they won't be picked up
by spatch later on and will end up being preserved in the code.

Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
drivers/infiniband/hw/hfi1/chip.c
drivers/infiniband/hw/qedr/verbs.c
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
drivers/scsi/bnx2i/bnx2i_hwi.c

index 612f041..12e67a9 100644 (file)
@@ -8365,7 +8365,7 @@ static inline void clear_recv_intr(struct hfi1_ctxtdata *rcd)
        struct hfi1_devdata *dd = rcd->dd;
        u32 addr = CCE_INT_CLEAR + (8 * rcd->ireg);
 
-       mmiowb();       /* make sure everything before is written */
+       mmiowb();
        write_csr(dd, addr, rcd->imask);
        /* force the above write on the chip and get a value back */
        (void)read_csr(dd, addr);
index 59ad420..4dab2b5 100644 (file)
@@ -3700,7 +3700,7 @@ int qedr_post_recv(struct ib_qp *ibqp, const struct ib_recv_wr *wr,
 
                if (rdma_protocol_iwarp(&dev->ibdev, 1)) {
                        writel(qp->rq.iwarp_db2_data.raw, qp->rq.iwarp_db2);
-                       mmiowb();       /* for second doorbell */
+                       mmiowb();
                }
 
                wr = wr->next;
index 2462e7a..1ed0685 100644 (file)
@@ -527,7 +527,7 @@ static inline void bnx2x_update_rx_prod(struct bnx2x *bp,
                REG_WR_RELAXED(bp, fp->ustorm_rx_prods_offset + i * 4,
                               ((u32 *)&rx_prods)[i]);
 
-       mmiowb(); /* keep prod updates ordered */
+       mmiowb();
 
        DP(NETIF_MSG_RX_STATUS,
           "queue[%d]:  wrote  bd_prod %u  cqe_prod %u  sge_prod %u\n",
index 626b491..e46786a 100644 (file)
@@ -5244,7 +5244,7 @@ static void bnx2x_update_eq_prod(struct bnx2x *bp, u16 prod)
 {
        /* No memory barriers */
        storm_memset_eq_prod(bp, prod, BP_FUNC(bp));
-       mmiowb(); /* keep prod updates ordered */
+       mmiowb();
 }
 
 static int  bnx2x_cnic_handle_cfc_del(struct bnx2x *bp, u32 cid,
index fae6f71..d56a78f 100644 (file)
@@ -280,7 +280,7 @@ static void bnx2i_ring_sq_dbell(struct bnx2i_conn *bnx2i_conn, int count)
        } else
                writew(count, ep->qp.ctx_base + CNIC_SEND_DOORBELL);
 
-       mmiowb(); /* flush posted PCI writes */
+       mmiowb();
 }