projects
/
profile
/
common
/
kernel-common.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b9bdcd9
)
aoe: error printed 1 too early
author
Roel Kluin
<roel.kluin@gmail.com>
Wed, 4 Mar 2009 08:07:57 +0000
(
00:07
-0800)
committer
David S. Miller
<davem@davemloft.net>
Wed, 4 Mar 2009 08:11:52 +0000
(
00:11
-0800)
with while (i-- > 0); i reaches -1 after the loop, so the test below is printed
one too early: 0 still means success.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/block/aoe/aoedev.c
patch
|
blob
|
history
diff --git
a/drivers/block/aoe/aoedev.c
b/drivers/block/aoe/aoedev.c
index
cc25057
..
eeea477
100644
(file)
--- a/
drivers/block/aoe/aoedev.c
+++ b/
drivers/block/aoe/aoedev.c
@@
-173,7
+173,7
@@
skbfree(struct sk_buff *skb)
return;
while (atomic_read(&skb_shinfo(skb)->dataref) != 1 && i-- > 0)
msleep(Sms);
- if (i <
=
0) {
+ if (i < 0) {
printk(KERN_ERR
"aoe: %s holds ref: %s\n",
skb->dev ? skb->dev->name : "netif",