Comment-only nits

diff --git a/handy.h b/handy.h
index 0dc7c0c..352a1c7 100644 (file)
--- a/handy.h
+++ b/handy.h
@@ -925,9 +925,10 @@ EXTCONST U32 PL_charclass[];
 /* To prevent S_scan_word in toke.c from hanging, we have to make sure that
  * IDFIRST is an alnum.  See
  * http://rt.perl.org/rt3/Ticket/Display.html?id=74022 for more detail than you
- * ever wanted to know about.  (In the ASCII range, there isn't a difference.)
- * This used to be not the XID version, but we decided to go with the more
- * modern Unicode definition */
+ * ever wanted to know about.  XXX It is unclear if this should extend to
+ * isIDFIRST_uni() which it hasn't so far.  (In the ASCII range, there isn't a
+ * difference.) This used to be not the XID version, but we decided to go with
+ * the more modern Unicode definition */
 #define isIDFIRST_utf8(p)       (isASCII(*(p))                                  \
                                 ? isIDFIRST_A(*(p))                             \
                                 : (UTF8_IS_DOWNGRADEABLE_START(*(p)))           \

diff --git a/regcomp.c b/regcomp.c
index a75f9fe..579dabe 100644 (file)
--- a/regcomp.c
+++ b/regcomp.c
@@ -5966,9 +5966,9 @@ S_invlist_set_len(pTHX_ SV* const invlist, const UV len)
      *           TO_INTERNAL_SIZE(len
      *                            - (*get_invlist_zero_addr(inv_list) ^ 1)));
      * But, this is only valid if len is not 0.  The consequences of not doing
-     * this is that the memory allocation code may think that the 1 more UV
-     * is being used than actually is, and so might do an unnecessary grow.
-     * That seems worth not bothering to make this the precise amount.
+     * this is that the memory allocation code may think that 1 more UV is
+     * being used than actually is, and so might do an unnecessary grow.  That
+     * seems worth not bothering to make this the precise amount.
      *
      * Note that when inverting, SvCUR shouldn't change */
 }

diff --git a/utf8.c b/utf8.c
index d51d83d..62fdf18 100644 (file)
--- a/utf8.c
+++ b/utf8.c
@@ -2172,8 +2172,9 @@ Perl_swash_fetch(pTHX_ SV *swash, const U8 *ptr, bool do_utf8)
            const UV code_point = utf8n_to_uvuni(ptr, UTF8_MAXBYTES, 0, 0);
 
            /* This outputs warnings for binary properties only, assuming that
-            * to_utf8_case() will output any.  Also, surrogates aren't checked
-            * for, as that would warn on things like /\p{Gc=Cs}/ */
+            * to_utf8_case() will output any for non-binary.  Also, surrogates
+            * aren't checked for, as that would warn on things like
+            * /\p{Gc=Cs}/ */
            SV** const bitssvp = hv_fetchs(hv, "BITS", FALSE);
            if (SvUV(*bitssvp) == 1) {
                Perl_warner(aTHX_ packWARN(WARN_NON_UNICODE),
@@ -2482,7 +2483,7 @@ S_swash_get(pTHX_ SV* swash, UV start, UV span)
     } /* while */
   go_out_list:
 
-    /* Invert if the data says it should be */
+    /* Invert if the data says it should be.  Assumes that bits == 1 */
     if (invert_it_svp && SvUV(*invert_it_svp)) {
 
        /* Unicode properties should come with all bits above PERL_UNICODE_MAX