ecore-drm2: Disable hardware rotation for outputs

Summary:
Setting output primary plane rotation is broken at the moment, so this
commit will disable that for now until this can be investigated

ref T7690

Depends on D8111

Reviewers: raster, cedric, zmike

Subscribers: cedric

Tags: #efl, #do_not_merge

Maniphest Tasks: T7690

Differential Revision: https://phab.enlightenment.org/D8112

diff --git a/src/lib/ecore_drm2/ecore_drm2_outputs.c b/src/lib/ecore_drm2/ecore_drm2_outputs.c
index a820f7d..f45b565 100644 (file)
--- a/src/lib/ecore_drm2/ecore_drm2_outputs.c
+++ b/src/lib/ecore_drm2/ecore_drm2_outputs.c
@@ -1522,6 +1522,12 @@ ecore_drm2_output_rotation_set(Ecore_Drm2_Output *output, int rotation)
 
    EINA_SAFETY_ON_NULL_RETURN_VAL(output, EINA_FALSE);
 
+#if 0
+   /* XXX: Disable hardware plane rotation for now as this has broken
+    * recently. The break happens because of an invalid argument,
+    * ie: the value being sent from pstate->rotation_map ends up being
+    * incorrect for some reason. I suspect the breakage to be from
+    * kernel drivers (linux 4.20.0) but have not confirmed that version */
    if (_ecore_drm2_use_atomic)
      {
         Eina_List *l;
@@ -1563,6 +1569,7 @@ ecore_drm2_output_rotation_set(Ecore_Drm2_Output *output, int rotation)
 err:
         sym_drmModeAtomicFree(req);
      }
+#endif
 
    return ret;
 }