Fix static analysis issues

Issues:
 - UNREACHABLE
 - UNINIT.CTOR

Change-Id: Ia4dc13bfd35f9a70d21b9a2a978a68f27e16ab69
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>

diff --git a/idlc/options.cc b/idlc/options.cc
index b9eaa761f1f9118f11af3c8e402311b4049cb2ba..435eb44b85a6ba6150130296f6948f5652ca156a 100644 (file)
--- a/idlc/options.cc
+++ b/idlc/options.cc
@@ -149,25 +149,35 @@ std::shared_ptr<Options> Options::Parse(int argc, char** argv) {
   if (cmd[CMD_HELP]) {
     options->PrintUsage();
     return std::shared_ptr<Options>(nullptr);
-  } else if (!cmd[CMD_PROXY] && !cmd[CMD_STUB]) {
+  }
+
+  if (!cmd[CMD_PROXY] && !cmd[CMD_STUB]) {
     std::cerr << "Stub or proxy must be specified." << std::endl;
     options->PrintSample();
     return std::shared_ptr<Options>(nullptr);
-  } else if (!opt[OPT_LANGUAGE]) {
+  }
+
+  if (!opt[OPT_LANGUAGE]) {
     std::cerr << "Select a language (C, C++, C#).." << std::endl;
     options->PrintSample();
     return std::shared_ptr<Options>(nullptr);
-  } else if (!opt[OPT_INPUT]) {
+  }
+
+  if (!opt[OPT_INPUT]) {
     std::cerr << "No input file." << std::endl;
     options->PrintSample();
     return std::shared_ptr<Options>(nullptr);
-  } else if (opt[OPT_INPUT]) {
+  }
+
+  if (opt[OPT_INPUT]) {
     std::ifstream in_file(options->input_.c_str());
     if (!in_file.good()) {
       std::cerr << "Not exist input file." << std::endl;
       return std::shared_ptr<Options>(nullptr);
     }
-  } else if (!opt[OPT_OUTPUT]) {
+  }
+
+  if (!opt[OPT_OUTPUT]) {
     std::cerr << "No out file." << std::endl;
     options->PrintSample();
     return std::shared_ptr<Options>(nullptr);

diff --git a/idlc/options.h b/idlc/options.h
index 3a09cfbaf6bc5bd0458181dc96f19fc1ebcec3e6..d0d2536a0d5ad44bf0f3953778e88b8dec1d7977 100644 (file)
--- a/idlc/options.h
+++ b/idlc/options.h
@@ -60,7 +60,7 @@ class Options {
   void PrintSample();
 
  private:
-  bool isProxy_;
+  bool isProxy_ = false;
   std::string language_;
   std::string input_;
   std::string output_;
@@ -73,4 +73,4 @@ class Options {
 
 }  // namespace tidl
 
-#endif  // TIDL_IDLC_OPTIONS_H_
\ No newline at end of file
+#endif  // TIDL_IDLC_OPTIONS_H_