New Buffer implementation allows greater than kMaxLength to be created.
So instead check if the passed value is a valid Smi.
PR-URL: https://github.com/nodejs/io.js/pull/1825
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
return env->ThrowTypeError("size must be a number >= 0");
}
- const uint32_t size = args[0]->Uint32Value();
- if (size > Buffer::kMaxLength) {
- return env->ThrowTypeError("size > Buffer::kMaxLength");
+ const int64_t size = args[0]->IntegerValue();
+ if (using_old_buffer) {
+ if (size > Buffer::kMaxLength)
+ return env->ThrowTypeError("size > Buffer::kMaxLength");
+ } else {
+ if (!IsValidSmi(size))
+ return env->ThrowRangeError("size is not a valid Smi");
}
Local<Object> obj = Object::New(env->isolate());
// #5126, "FATAL ERROR: v8::Object::SetIndexedPropertiesToExternalArrayData()
// length exceeds max acceptable value"
assert.throws(function() {
- crypto.randomBytes(0x3fffffff + 1);
+ crypto.randomBytes((-1 >>> 0) + 1);
}, TypeError);