Reland of Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due...
authorbenjaminwagner <benjaminwagner@google.com>
Thu, 1 Oct 2015 23:25:51 +0000 (16:25 -0700)
committerCommit bot <commit-bot@chromium.org>
Thu, 1 Oct 2015 23:25:51 +0000 (16:25 -0700)
Reason for revert:
Not fixed. :-(

Original issue's description:
> Revert of Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 (patchset #1 id:1 of https://codereview.chromium.org/1365683003/ )
>
> Reason for revert:
> should hopefully be fixed, please reland if not.
>
> Original issue's description:
> > Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373
> >
> > BUG=skia:4373
> >
> > Committed: https://skia.googlesource.com/skia/+/3420d2796bad5ce553efb9909790ea72e578dc47
>
> TBR=borenet@google.com,benjaminwagner@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:4373
>
> Committed: https://skia.googlesource.com/skia/+/52f8deba607fd67558b57551cd43406c8b743072

TBR=borenet@google.com,joshualitt@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4373

Review URL: https://codereview.chromium.org/1375733003

tools/nanobench_flags.json
tools/nanobench_flags.py

index 6084ad1..049bf54 100644 (file)
@@ -49,7 +49,9 @@
     "~blurroundrect", 
     "~patch_grid", 
     "~desk_carsvg", 
-    "~GLInstancedArraysBench"
+    "~GLInstancedArraysBench", 
+    "~GLVertexAttributesBench", 
+    "~GLVec4ScalarBench"
   ], 
   "Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind": [
     "--scales", 
index f11ea1f..86d7203 100755 (executable)
@@ -69,6 +69,8 @@ def get_args(bot):
     match.append('~desk_unicodetable')
   if 'GalaxyS4' in bot:
     match.append('~GLInstancedArraysBench')  # skia:4371
+    # skia:4373
+    match.extend(['~GLVertexAttributesBench', '~GLVec4ScalarBench'])
 
   if 'iOS' in bot:
     match.append('~blurroundrect')