connection: don't append to uninitialized metadata
authorDaniel Mack <zonque@gmail.com>
Tue, 24 Jun 2014 13:41:47 +0000 (15:41 +0200)
committerDaniel Mack <zonque@gmail.com>
Tue, 24 Jun 2014 13:41:47 +0000 (15:41 +0200)
kmsg->meta is only valid if conn_src != NULL.

connection.c

index 7fc63425c2d6c366b64185a141601d90610af196..85ffa5acd1a4a490b63c59886a38a5e341721b62 100644 (file)
@@ -1373,8 +1373,9 @@ int kdbus_conn_kmsg_send(struct kdbus_ep *ep,
         */
        mutex_lock(&bus->lock);
        list_for_each_entry(c, &bus->monitors_list, monitor_entry) {
-               kdbus_meta_append(kmsg->meta, conn_src, kmsg->seq,
-                                 c->attach_flags);
+               if (conn_src)
+                       kdbus_meta_append(kmsg->meta, conn_src, kmsg->seq,
+                                         c->attach_flags);
                kdbus_conn_queue_insert(c, NULL, kmsg, NULL);
        }
        mutex_unlock(&bus->lock);