dm persistent data: switch exit_ro_spine to return void
authorZhiqiang Liu <liuzhiqiang26@huawei.com>
Wed, 15 Apr 2020 11:57:31 +0000 (19:57 +0800)
committerMike Snitzer <snitzer@redhat.com>
Fri, 15 May 2020 14:29:35 +0000 (10:29 -0400)
In commit 4c7da06f5a78 ("dm persistent data: eliminate unnecessary
return values"), r value in exit_ro_spine will not change, so
exit_ro_spine doesn't need a return value.

Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/persistent-data/dm-btree-internal.h
drivers/md/persistent-data/dm-btree-spine.c

index a240990a7f3339047e45a4b45087a8a3d0ca30fe..55a4096f1334f11cad9e394a979b41ee5d57370b 100644 (file)
@@ -68,7 +68,7 @@ struct ro_spine {
 };
 
 void init_ro_spine(struct ro_spine *s, struct dm_btree_info *info);
-int exit_ro_spine(struct ro_spine *s);
+void exit_ro_spine(struct ro_spine *s);
 int ro_step(struct ro_spine *s, dm_block_t new_child);
 void ro_pop(struct ro_spine *s);
 struct btree_node *ro_node(struct ro_spine *s);
index b27b8091a1ca4f649240e074a7bee564285dd30d..e03cb9e4877381c4bb6fc17da2b7e73890073793 100644 (file)
@@ -132,15 +132,13 @@ void init_ro_spine(struct ro_spine *s, struct dm_btree_info *info)
        s->nodes[1] = NULL;
 }
 
-int exit_ro_spine(struct ro_spine *s)
+void exit_ro_spine(struct ro_spine *s)
 {
-       int r = 0, i;
+       int i;
 
        for (i = 0; i < s->count; i++) {
                unlock_block(s->info, s->nodes[i]);
        }
-
-       return r;
 }
 
 int ro_step(struct ro_spine *s, dm_block_t new_child)