cavium: Return negative value when pci_alloc_irq_vectors() fails
authorZheyu Ma <zheyuma97@gmail.com>
Mon, 18 Oct 2021 02:16:22 +0000 (02:16 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Nov 2021 13:03:41 +0000 (14:03 +0100)
[ Upstream commit b2cddb44bddc1a9c5949a978bb454bba863264db ]

During the process of driver probing, the probe function should return < 0
for failure, otherwise, the kernel will treat value > 0 as success.

Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/cavium/thunder/nic_main.c

index 9361f96..816453a 100644 (file)
@@ -1193,7 +1193,7 @@ static int nic_register_interrupts(struct nicpf *nic)
                dev_err(&nic->pdev->dev,
                        "Request for #%d msix vectors failed, returned %d\n",
                           nic->num_vec, ret);
-               return 1;
+               return ret;
        }
 
        /* Register mailbox interrupt handler */