video: fbdev: via: Fix set but not used warning for mode_crt_table
authorSam Ravnborg <sam@ravnborg.org>
Sat, 28 Nov 2020 22:40:57 +0000 (23:40 +0100)
committerSam Ravnborg <sam@ravnborg.org>
Mon, 30 Nov 2020 19:04:24 +0000 (20:04 +0100)
Fix warning by deleting the variable. The function call
viafb_get_best_mode() was verified to have no side-effects,
and thus could be dropped too.

v2:
  - Update subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: linux-fbdev@vger.kernel.org
Cc: Lee Jones <lee.jones@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20201128224114.1033617-12-sam@ravnborg.org
drivers/video/fbdev/via/lcd.c

index 4a86940..088b962 100644 (file)
@@ -537,11 +537,9 @@ void viafb_lcd_set_mode(const struct fb_var_screeninfo *var, u16 cxres,
        u32 clock;
        struct via_display_timing timing;
        struct fb_var_screeninfo panel_var;
-       const struct fb_videomode *mode_crt_table, *panel_crt_table;
+       const struct fb_videomode *panel_crt_table;
 
        DEBUG_MSG(KERN_INFO "viafb_lcd_set_mode!!\n");
-       /* Get mode table */
-       mode_crt_table = viafb_get_best_mode(set_hres, set_vres, 60);
        /* Get panel table Pointer */
        panel_crt_table = viafb_get_best_mode(panel_hres, panel_vres, 60);
        viafb_fill_var_timing_info(&panel_var, panel_crt_table);