Removing warnings from modules: download, exif.

Using cppcheck (with --enable=all flag).

[Verification] TCT result:
Before:
 download  98, 39%
 exif      100.00%
After:
 download  98, 39%
 exif      100.00%

Change-Id: I0e8f08874262be9c4742a549958a24264bef9a24
Signed-off-by: Anna Niznik <a.niznik@samsung.com>
Signed-off-by: Pawel Sikorski <p.sikorski@samsung.com>

diff --git a/src/download/download_instance.cc b/src/download/download_instance.cc
index bd73f46164aaab3eab641ff04694fb777e1e920e..e1b8325dad0f08c102e675dc2687fd57e5d5c7ed 100755 (executable)
--- a/src/download/download_instance.cc
+++ b/src/download/download_instance.cc
@@ -69,7 +69,7 @@ DownloadInstance::~DownloadInstance() {
   LoggerD("Entered");
   int ret;
   for (DownloadCallbackMap::iterator it = downCbMap.begin();
-    it != downCbMap.end(); it++) {
+    it != downCbMap.end(); ++it) {
     DownloadInfoPtr diPtr = it->second->instance->diMap[it->second->callbackId];
     SLoggerD("~DownloadInstance() for callbackID %d Called", it->second->callbackId);
 

diff --git a/src/exif/exif_information.cc b/src/exif/exif_information.cc
index be79fd173283fed18e3ff479adb33e59dda900f4..dce7ff3448a76d46d66827564b6b1537db61a9da 100755 (executable)
--- a/src/exif/exif_information.cc
+++ b/src/exif/exif_information.cc
@@ -59,7 +59,7 @@ IsoSpeedRatingsVector jsonArray2vector(const picojson::value& a) {
 
   picojson::array v = a.get<picojson::array>();
 
-  for (picojson::array::iterator it = v.begin(); it != v.end(); it++) {
+  for (picojson::array::iterator it = v.begin(); it != v.end(); ++it) {
     if ((*it).is<double>())
       result.push_back(static_cast<long long int>((*it).get<double>()));
   }
@@ -84,7 +84,7 @@ ExifInformation::ExifInformation(const picojson::value& args) {
   }
 
   for (AttributeMap::const_iterator it = ExifInformationAttributeMap.begin();
-      it != ExifInformationAttributeMap.end(); it++) {
+      it != ExifInformationAttributeMap.end(); ++it) {
     std::string attributeName = it->second;
     picojson::value v = args.get(attributeName);
     if (!common::IsNull(v)) {

diff --git a/src/exif/exif_instance.cc b/src/exif/exif_instance.cc
index aabd6a3a7156a12a074b6393a059f7210e204ac9..fb54baa237f1e301605f8582fcad763a6ad626c1 100755 (executable)
--- a/src/exif/exif_instance.cc
+++ b/src/exif/exif_instance.cc
@@ -87,7 +87,6 @@ void ExifInstance::ExifManagerGetExifInfo(const picojson::value& args, picojson:
 void ExifInstance::ExifManagerSaveExifInfo(const picojson::value& args,
                                            picojson::object& out) {
   LoggerD("Entered");
-  const std::string& uri = args.get("uri").get<std::string>();
 
   const double callback_id = args.get("callbackId").get<double>();
   auto get = [=](const std::shared_ptr<JsonValue>& response) -> void {

diff --git a/src/exif/exif_util.cc b/src/exif/exif_util.cc
index 0061856c82e7650caf894e493bd05d87c083c013..6a703d63474f9dbbedef87c25a9c4af39e213861 100755 (executable)
--- a/src/exif/exif_util.cc
+++ b/src/exif/exif_util.cc
@@ -230,7 +230,7 @@ std::string ExifUtil::convertUriToPath(const std::string& str) {
 std::string ExifUtil::ltrim(const std::string& s) {
   std::string str = s;
   std::string::iterator i;
-  for (i = str.begin(); i != str.end(); i++) {
+  for (i = str.begin(); i != str.end(); ++i) {
     if (!isspace(*i)) {
       break;
     }
@@ -246,7 +246,7 @@ std::string ExifUtil::ltrim(const std::string& s) {
 
 time_t ExifUtil::exifDateTimeOriginalToTimeT(const char* string) {
   int year, month, day, hour, min, sec;
-  if (sscanf(string, "%d:%d:%d %d:%d:%d",
+  if (sscanf(string, "%5d:%5d:%5d %5d:%5d:%5d",
       &year, &month, &day, &hour, &min, &sec) >= 6) {
     return convertToTimeT(year, month, day, hour, min, sec);
   }

diff --git a/src/exif/rational.cc b/src/exif/rational.cc
index e08ebfb5b5a7e6e7da4aa6e0c59f914bfbd7cc08..3aaaf91163183ca28eddf330615bc9a4d8315885 100755 (executable)
--- a/src/exif/rational.cc
+++ b/src/exif/rational.cc
@@ -205,7 +205,7 @@ Rational Rational::createFromExposureTimeString(const std::string& exp_time) {
 
   if (fraction_part.length() > 0) {
     if (sscanf(
-          fraction_part.c_str(), "%ld/%ld", &nominator, &denominator) != 2) {
+          fraction_part.c_str(), "%5ld/%5ld", &nominator, &denominator) != 2) {
       LoggerD("Failed to parse nominator/denominator string: [%s]",
           fraction_part.c_str());
       return Rational::createInvalid();