Fix coverity issue 45/244145/1 accepted/tizen/unified/20200918.123654 submit/tizen/20200916.012329 submit/tizen/20200917.011100 submit/tizen/20200917.223734
authorMinje Ahn <minje.ahn@samsung.com>
Tue, 15 Sep 2020 08:34:22 +0000 (17:34 +0900)
committerMinje Ahn <minje.ahn@samsung.com>
Tue, 15 Sep 2020 08:34:22 +0000 (17:34 +0900)
Change-Id: I5cd002b47ea317c7943cdafb94eb33c02598da17
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
formats/ffmpeg/mm_file_format_imelody.c
formats/ffmpeg/mm_file_format_mmf.c

index b284fd3..a36fb24 100755 (executable)
@@ -171,7 +171,7 @@ static int __AvMIDISetBeat(const char *pMelodyBuf)
                beatValue = g_strndup(found + strlen(IMY_KEY_BEAT), 3);
                /* No need to check integer bound */
                bpm = atoi(beatValue);
-
+               g_free(beatValue);
                if (bpm < 25 || bpm > 900)
                        bpm = 120;
        }
@@ -976,6 +976,8 @@ static int __get_imelody_tag(const char *uriname, tMMFileImelodyTagInfo *tags)
                }
        }
 
+       g_strfreev(taglist);
+
        return MMFILE_FORMAT_SUCCESS;
 }
 
index e2cb9e4..8745e71 100755 (executable)
@@ -1156,14 +1156,14 @@ static bool __mmf_SeqDataCheck3(PLOADINFO psLoad, unsigned char bSmafType)
                case 0xA0:
                case 0xB0:
                case 0xE0:
-                       bTemp = psLoad->pfnGetByte(psHuf);      /*B0: Conrol number, E0:Pitch Bend Change LSB*/
+                       psLoad->pfnGetByte(psHuf);      /*B0: Conrol number, E0:Pitch Bend Change LSB*/
                        dIndex++;
-                       bTemp = psLoad->pfnGetByte(psHuf);      /*B0: Conrol value, E0:Pitch Bend Change MSB*/
+                       psLoad->pfnGetByte(psHuf);      /*B0: Conrol value, E0:Pitch Bend Change MSB*/
                        dIndex++;
                        break;
                case 0xC0:
                case 0xD0:
-                       bTemp = psLoad->pfnGetByte(psHuf);
+                       psLoad->pfnGetByte(psHuf);
                        dIndex++;
                        break;
                default:
@@ -1391,6 +1391,7 @@ static unsigned char __mmf_DecodeByte3L(PHUFFMANINFO psHuf)
 static bool __mmf_TrackChunkCheck3(PLOADINFO psLoad)
 {
        PTRACKINFO psTrack;
+       bool result = false;
 
        mm_file_retv_if_fails(psLoad->sTrack_Info[5].pbMtr, false);
 
@@ -1424,8 +1425,9 @@ static bool __mmf_TrackChunkCheck3(PLOADINFO psLoad)
        }
 
        psTrack->dMtsqSize = psLoad->sHuffman_Info.dSeqSize;
+       result = __mmf_STSPCheck(psTrack);
        psTrack->dMtsqSize = psLoad->sHuffman_Info.dMtsqSize;
-       mm_file_retv_if_fails(__mmf_STSPCheck(psTrack), false);
+       mm_file_retv_if_fails(result, false);
        mm_file_retv_if_fails(__mmf_SeqDataCheck3(psLoad, AV_MMF_SMAF_TYPE_MA3), false);
 
        psLoad->dPlayTime       = psTrack->dPlayTime;