fat: remove i_version handling from fat_update_time
authorJeff Layton <jlayton@kernel.org>
Thu, 10 Aug 2023 13:12:04 +0000 (09:12 -0400)
committerChristian Brauner <brauner@kernel.org>
Fri, 11 Aug 2023 07:04:56 +0000 (09:04 +0200)
commit 6bb885ecd746 (fat: add functions to update and truncate
timestamps appropriately") added an update_time routine for fat. That
patch added a section for handling the S_VERSION bit, even though FAT
doesn't enable SB_I_VERSION and the S_VERSION bit will never be set when
calling it.

Remove the section for handling S_VERSION since it's effectively dead
code, and will be problematic vs. future changes.

Cc: Frank Sorenson <sorenson@redhat.com>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Frank Sorenson <sorenson@redhat.com>
Message-Id: <20230810-ctime-fat-v1-1-327598fd1de8@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/fat/misc.c

index 67006ea..6204367 100644 (file)
@@ -354,9 +354,6 @@ int fat_update_time(struct inode *inode, struct timespec64 *now, int flags)
                        dirty_flags |= I_DIRTY_SYNC;
        }
 
-       if ((flags & S_VERSION) && inode_maybe_inc_iversion(inode, false))
-               dirty_flags |= I_DIRTY_SYNC;
-
        __mark_inode_dirty(inode, dirty_flags);
        return 0;
 }