bus_driver_send_ack_reply: Make available to other modules
authorSimon McVittie <smcv@collabora.com>
Wed, 21 Jun 2017 15:25:01 +0000 (16:25 +0100)
committerSimon McVittie <smcv@collabora.com>
Thu, 29 Jun 2017 14:43:25 +0000 (15:43 +0100)
Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: Philip Withnall <withnall@endlessm.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=101567

bus/driver.c
bus/driver.h

index 964a943..cd0a714 100644 (file)
@@ -966,11 +966,11 @@ bus_driver_handle_activate_service (DBusConnection *connection,
   return retval;
 }
 
-static dbus_bool_t
-send_ack_reply (DBusConnection *connection,
-                BusTransaction *transaction,
-                DBusMessage    *message,
-                DBusError      *error)
+dbus_bool_t
+bus_driver_send_ack_reply (DBusConnection *connection,
+                           BusTransaction *transaction,
+                           DBusMessage    *message,
+                           DBusError      *error)
 {
   DBusMessage *reply;
 
@@ -1266,8 +1266,7 @@ bus_driver_handle_update_activation_environment (DBusConnection *connection,
         }
     }
 
-  if (!send_ack_reply (connection, transaction,
-                       message, error))
+  if (!bus_driver_send_ack_reply (connection, transaction, message, error))
     goto out;
 
   retval = TRUE;
@@ -1354,8 +1353,7 @@ bus_driver_handle_add_match (DBusConnection *connection,
       goto failed;
     }
 
-  if (!send_ack_reply (connection, transaction,
-                       message, error))
+  if (!bus_driver_send_ack_reply (connection, transaction, message, error))
     {
       bus_matchmaker_remove_rule (matchmaker, rule);
       goto failed;
@@ -1405,8 +1403,7 @@ bus_driver_handle_remove_match (DBusConnection *connection,
   /* Send the ack before we remove the rule, since the ack is undone
    * on transaction cancel, but rule removal isn't.
    */
-  if (!send_ack_reply (connection, transaction,
-                       message, error))
+  if (!bus_driver_send_ack_reply (connection, transaction, message, error))
     goto failed;
 
   matchmaker = bus_connection_get_matchmaker (connection);
@@ -2249,7 +2246,7 @@ bus_driver_handle_become_monitor (DBusConnection *connection,
   /* Send the ack before we remove the rule, since the ack is undone
    * on transaction cancel, but becoming a monitor isn't.
    */
-  if (!send_ack_reply (connection, transaction, message, error))
+  if (!bus_driver_send_ack_reply (connection, transaction, message, error))
     goto out;
 
   if (!bus_connection_be_monitor (connection, transaction, &rules, error))
@@ -2337,7 +2334,7 @@ bus_driver_handle_ping (DBusConnection *connection,
                         DBusMessage *message,
                         DBusError *error)
 {
-  return send_ack_reply (connection, transaction, message, error);
+  return bus_driver_send_ack_reply (connection, transaction, message, error);
 }
 
 static dbus_bool_t bus_driver_handle_get (DBusConnection *connection,
index 36a1db9..ac1289d 100644 (file)
@@ -62,5 +62,9 @@ BusDriverFound bus_driver_get_conn_helper (DBusConnection  *connection,
                                            const char     **name_p,
                                            DBusConnection **peer_conn_p,
                                            DBusError       *error);
+dbus_bool_t bus_driver_send_ack_reply     (DBusConnection  *connection,
+                                           BusTransaction  *transaction,
+                                           DBusMessage     *message,
+                                           DBusError       *error);
 
 #endif /* BUS_DRIVER_H */