drm/i915: Remove pointer indirection for hangcheck_state local

Use the local on-stack struct directly rather than hide it behind a
pointer. This should be both clearer for the reader and the compiler (we
rely on the compiler seeing through the functions to spot uninitialized
uses of the local).

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20171219130948.6282-1-chris@chris-wilson.co.uk

diff --git a/drivers/gpu/drm/i915/intel_hangcheck.c b/drivers/gpu/drm/i915/intel_hangcheck.c
index 0acd9dd3ed5ceb01d1295bfcde7ebad1e71a05f7..31f01d64c0212cee75f40b8f6f462c7b7f500147 100644 (file)
--- a/drivers/gpu/drm/i915/intel_hangcheck.c
+++ b/drivers/gpu/drm/i915/intel_hangcheck.c
@@ -429,18 +429,18 @@ static void i915_hangcheck_elapsed(struct work_struct *work)
        intel_uncore_arm_unclaimed_mmio_detection(dev_priv);
 
        for_each_engine(engine, dev_priv, id) {
-               struct intel_engine_hangcheck cur_state, *hc = &cur_state;
                const bool busy = intel_engine_has_waiter(engine);
+               struct intel_engine_hangcheck hc;
 
                semaphore_clear_deadlocks(dev_priv);
 
-               hangcheck_load_sample(engine, hc);
-               hangcheck_accumulate_sample(engine, hc);
-               hangcheck_store_sample(engine, hc);
+               hangcheck_load_sample(engine, &hc);
+               hangcheck_accumulate_sample(engine, &hc);
+               hangcheck_store_sample(engine, &hc);
 
                if (engine->hangcheck.stalled) {
                        hung |= intel_engine_flag(engine);
-                       if (hc->action != ENGINE_DEAD)
+                       if (hc.action != ENGINE_DEAD)
                                stuck |= intel_engine_flag(engine);
                }