parsebin: Fix leak
authorEdward Hervey <edward@centricular.com>
Mon, 31 Oct 2022 15:06:45 +0000 (16:06 +0100)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Fri, 4 Nov 2022 17:59:21 +0000 (17:59 +0000)
Release the reference on the collection which was given to us when extracting it
from the event/message.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3319>

subprojects/gst-plugins-base/gst/playback/gstparsebin.c

index 0f442b2..d2f1b7f 100644 (file)
@@ -1219,6 +1219,7 @@ copy_sticky_events (GstPad * pad, GstEvent ** eventptr, gpointer user_data)
       GstStreamCollection *collection = NULL;
       gst_event_parse_stream_collection (event, &collection);
       gst_parse_pad_update_stream_collection (ppad, collection);
+      gst_object_unref (collection);
       break;
     }
     default:
@@ -4124,6 +4125,7 @@ gst_parse_pad_event (GstPad * pad, GstPadProbeInfo * info, gpointer user_data)
       gst_element_post_message (GST_ELEMENT (parsepad->parsebin),
           gst_message_new_stream_collection (GST_OBJECT (parsepad->parsebin),
               collection));
+      gst_object_unref (collection);
       break;
     }
     case GST_EVENT_EOS:{