x86/apic/uv: Fix inconsistent destination mode
authorThomas Gleixner <tglx@linutronix.de>
Sat, 24 Oct 2020 21:35:03 +0000 (22:35 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 28 Oct 2020 19:26:24 +0000 (20:26 +0100)
The UV x2apic is strictly using physical destination mode, but
apic::dest_logical is initialized with APIC_DEST_LOGICAL.

This does not matter much because UV does not use any of the generic
functions which use apic::dest_logical, but is still inconsistent.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20201024213535.443185-4-dwmw2@infradead.org
arch/x86/kernel/apic/x2apic_uv_x.c

index 714233c..9ade9e6 100644 (file)
@@ -811,7 +811,7 @@ static struct apic apic_x2apic_uv_x __ro_after_init = {
        .irq_dest_mode                  = 0, /* Physical */
 
        .disable_esr                    = 0,
-       .dest_logical                   = APIC_DEST_LOGICAL,
+       .dest_logical                   = APIC_DEST_PHYSICAL,
        .check_apicid_used              = NULL,
 
        .init_apic_ldr                  = uv_init_apic_ldr,