gst/gstregistrybinary.c: If gst_registry_add_plugin() fails our reference to the...

Original commit message from CVS:
* gst/gstregistrybinary.c: (gst_registry_binary_load_plugin):
If gst_registry_add_plugin() fails our reference to the plugin is
invalid so don't try to use it anymore and instead error out.

diff --git a/ChangeLog b/ChangeLog
index f902cc478ca46fc7071ab7cfd4eaf7f786122705..8f37656a075bf2372022e75662fa2ed970d414aa 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2008-04-13  Sebastian Dröge  <slomo@circular-chaos.org>
+
+       * gst/gstregistrybinary.c: (gst_registry_binary_load_plugin):
+       If gst_registry_add_plugin() fails our reference to the plugin is
+       invalid so don't try to use it anymore and instead error out.
+
 2008-04-12  Tim-Philipp Müller  <tim at centricular dot net>
 
        * tools/gst-xmlinspect.c: (print_element_info), (main):

diff --git a/gst/gstregistrybinary.c b/gst/gstregistrybinary.c
index 112b7f1fa5287a5c183f3c6db0d3f745ab8f1d3b..5eb2a15e0ba6fa8f2bd9dcb9a88cadaa7b609b3b 100644 (file)
--- a/gst/gstregistrybinary.c
+++ b/gst/gstregistrybinary.c
@@ -857,7 +857,10 @@ gst_registry_binary_load_plugin (GstRegistry * registry, gchar ** in)
   GST_LOG ("read strings for '%s'", plugin->desc.name);
 
   plugin->basename = g_path_get_basename (plugin->filename);
-  gst_registry_add_plugin (registry, plugin);
+
+  if (!gst_registry_add_plugin (registry, plugin))
+    return FALSE;
+
   GST_INFO ("Added plugin '%s' plugin with %d features from binary registry",
       plugin->desc.name, pe->nfeatures);
   for (i = 0; i < pe->nfeatures; i++) {