hpsa: cleanup update scsi devices
authorDon Brace <don.brace@pmcs.com>
Sat, 18 Jul 2015 16:12:49 +0000 (11:12 -0500)
committerJames Bottomley <JBottomley@Odin.com>
Wed, 26 Aug 2015 23:26:51 +0000 (16:26 -0700)
showing that tables have been updated unnecessarily.

Reviewed-by: Kevin Barnett <kevin.barnett@pmcs.com>
Reviewed-by: Scott Teel <scott.teel@pmcs.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: Don Brace <don.brace@pmcs.com>
Signed-off-by: James Bottomley <JBottomley@Odin.com>
drivers/scsi/hpsa.c

index 43c34a6..9d32913 100644 (file)
@@ -1379,8 +1379,9 @@ static inline int device_updated(struct hpsa_scsi_dev_t *dev1,
                return 1;
        if (dev1->offload_enabled != dev2->offload_enabled)
                return 1;
-       if (dev1->queue_depth != dev2->queue_depth)
-               return 1;
+       if (!is_logical_dev_addr_mode(dev1->scsi3addr))
+               if (dev1->queue_depth != dev2->queue_depth)
+                       return 1;
        return 0;
 }
 
@@ -3889,7 +3890,6 @@ static void hpsa_update_scsi_devices(struct ctlr_info *h, int hostno)
                        else if (!(h->transMethod & CFGTBL_Trans_io_accel1 ||
                                h->transMethod & CFGTBL_Trans_io_accel2))
                                break;
-
                        hpsa_get_ioaccel_drive_info(h, this_device,
                                                lunaddrbytes, id_phys);
                        hpsa_get_path_info(this_device, lunaddrbytes, id_phys);