bnx2x: Restore a call to config_init
authorEilon Greenstein <eilong@broadcom.com>
Fri, 6 Sep 2013 09:55:02 +0000 (12:55 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 6 Sep 2013 18:43:49 +0000 (14:43 -0400)
Commit c0a77ec74f295013d7ba3204dd3ed25fccf83cb4 'bnx2x: Add missing braces in
bnx2x:bnx2x_link_initialize' identified indentation problem, but resolved it
by adding braces instead of fixing the indentation. The braces now prevents a
config_init call in some cases, though it should be called regardless of that
condition. This patch removes the braces and fix the confusing indentation
that caused this mess.

Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
CC: Dave Jones <davej@redhat.com>
Tested-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c

index 6645684..d60a2ea 100644 (file)
@@ -6501,13 +6501,10 @@ static int bnx2x_link_initialize(struct link_params *params,
                struct bnx2x_phy *phy = &params->phy[INT_PHY];
                if (vars->line_speed == SPEED_AUTO_NEG &&
                    (CHIP_IS_E1x(bp) ||
-                    CHIP_IS_E2(bp))) {
+                    CHIP_IS_E2(bp)))
                        bnx2x_set_parallel_detection(phy, params);
-                       if (params->phy[INT_PHY].config_init)
-                               params->phy[INT_PHY].config_init(phy,
-                                                                params,
-                                                                vars);
-               }
+               if (params->phy[INT_PHY].config_init)
+                       params->phy[INT_PHY].config_init(phy, params, vars);
        }
 
        /* Init external phy*/