mtd: rawnand: brcmnand: Stop using nand_release()

This helper is not very useful and very often people get confused:
they use nand_release() instead of nand_cleanup().

Let's stop using nand_release() by calling mtd_device_unregister() and
nand_cleanup() directly.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: Kamal Dasu <kdasu.kdev@gmail.com>
Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-5-miquel.raynal@bootlin.com

diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
index 30a9a8d..132e1da 100644 (file)
--- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
+++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
@@ -3048,9 +3048,15 @@ int brcmnand_remove(struct platform_device *pdev)
 {
        struct brcmnand_controller *ctrl = dev_get_drvdata(&pdev->dev);
        struct brcmnand_host *host;
+       struct nand_chip *chip;
+       int ret;
 
-       list_for_each_entry(host, &ctrl->host_list, node)
-               nand_release(&host->chip);
+       list_for_each_entry(host, &ctrl->host_list, node) {
+               chip = &host->chip;
+               ret = mtd_device_unregister(nand_to_mtd(chip));
+               WARN_ON(ret);
+               nand_cleanup(chip);
+       }
 
        clk_disable_unprepare(ctrl->clk);