Replace uses of non-standard C++:
authorRob Hughes <robert.hughes@arm.com>
Mon, 23 Sep 2019 15:24:05 +0000 (16:24 +0100)
committerRob Hughes <robert.hughes@arm.com>
Mon, 23 Sep 2019 15:51:15 +0000 (16:51 +0100)
* Variable-length array replaced with std::vector
* "and" replaced with "&&" (OK, this one is standard but MSVC doesn't
like it and it's inconsistent with the rest of the codebase)
* Replace u_int8_t with uint8_t

Change-Id: I7b968a2cfa85a5492a2a547364464c594efb067b
Signed-off-by: Rob Hughes <robert.hughes@arm.com>
src/backends/backendsCommon/WorkloadUtils.cpp
tests/NetworkExecutionUtils/NetworkExecutionUtils.hpp

index 3185ba0..9e008ca 100644 (file)
@@ -82,7 +82,7 @@ ConstTensor ReorderWeightChannelsForAcl(const ConstTensor& weightHandle, DataLay
             break;
     }
 
-    DataType weightAclOrder[height*width*inputChannels*multiplier];
+    std::vector<DataType> weightAclOrder(height*width*inputChannels*multiplier);
     unsigned int destinationWeightsChannel;
     unsigned int totalChannels = inputChannels * multiplier;
     unsigned int channelSize   = height * width;
@@ -105,7 +105,7 @@ ConstTensor ReorderWeightChannelsForAcl(const ConstTensor& weightHandle, DataLay
         }
     }
 
-    ::memcpy(permuteBuffer, weightAclOrder, weightHandle.GetInfo().GetNumBytes());
+    ::memcpy(permuteBuffer, weightAclOrder.data(), weightHandle.GetInfo().GetNumBytes());
     return ConstTensor(weightHandle.GetInfo(), permuteBuffer);
 }
 
@@ -158,7 +158,7 @@ armnn::ConstTensor ConvertWeightTensorFromArmnnToAcl(const ConstCpuTensorHandle*
     ConstTensor weightPermuted = PermuteTensor(weightTensor, permutationVector, permuteBuffer);
 
     // Shuffle the weights data to obtain the channel order needed used by Acl
-    if (multiplier > 1 and inputChannels > 1 and dataLayout == DataLayout::NCHW)
+    if (multiplier > 1 && inputChannels > 1 && dataLayout == DataLayout::NCHW)
     {
         switch (weightPermuted.GetDataType())
         {
index 635eaf3..eefe628 100644 (file)
@@ -161,7 +161,7 @@ auto ParseDataArray<armnn::DataType::QuantisedAsymm8>(std::istream& stream,
                                    [&quantizationScale, &quantizationOffset](const std::string & s)
                                    {
                                        return boost::numeric_cast<uint8_t>(
-                                           armnn::Quantize<u_int8_t>(std::stof(s),
+                                           armnn::Quantize<uint8_t>(std::stof(s),
                                                                      quantizationScale,
                                                                      quantizationOffset));
                                    });