Fix compiler warnings for uBrowser
authorLeszek Syroka <l.syroka@partner.samsung.com>
Tue, 26 Jan 2016 11:40:14 +0000 (12:40 +0100)
committerYoungsoo Choi <kenshin.choi@samsung.com>
Tue, 10 Jul 2018 07:55:23 +0000 (07:55 +0000)
Warnings caused by calling deprecated API have been erased. Switching
tab to private mode in uBrowser have been removed because it is deprecated
and will not be supported in further versions of Chromium.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=15664

Reviewed by: sns.park

Change-Id: Ideb1cb9700e951d2e759494eed99ecdde6c32bd6
Signed-off-by: Leszek Syroka <l.syroka@partner.samsung.com>
tizen_src/ewk/ubrowser/window.cc
tizen_src/ewk/ubrowser/window.h
tizen_src/ewk/ubrowser/window_ui.cc
tizen_src/ewk/ubrowser/window_ui.h

index 0bb63af..c8b76e0 100644 (file)
@@ -244,12 +244,6 @@ bool Window::IsFormProfileEnabled() const {
   return ewk_settings_form_profile_data_enabled_get(settings);
 }
 
-bool Window::IsPrivateBrowsingEnabled() const {
-  log_trace("%s", __PRETTY_FUNCTION__);
-  Ewk_Settings* settings = GetEwkSettings();
-  return ewk_settings_private_browsing_enabled_get(settings);
-}
-
 double Window::GetScale() const {
   log_trace("%s", __PRETTY_FUNCTION__);
   return ewk_view_scale_get(web_view_);
index 5a19c4a..2d489f7 100644 (file)
@@ -43,7 +43,6 @@ class Window {
   bool IsRememberFormDataEnabled() const;
   bool IsRememberPasswordEnabled() const;
   bool IsFormProfileEnabled() const;
-  bool IsPrivateBrowsingEnabled() const;
   double GetScale() const;
   void GetScaleRange(double* minScale, double* maxScale) const;
   void SetScale(double);
index d153618..af80e8a 100644 (file)
@@ -252,14 +252,6 @@ Evas_Object* WindowUI::CreateExtraActionsMenu(Evas_Object* parent) {
                              &WindowUI::OnAutoFillDisabled, this);
   }
 
-  if (window_.IsPrivateBrowsingEnabled()) {
-    elm_ctxpopup_item_append(menu_, "Disable Private Browsing", NULL,
-                             &WindowUI::OnPrivateBrowsingChange, this);
-  } else {
-    elm_ctxpopup_item_append(menu_, "Enable PrivateBrowsing", NULL,
-                             &WindowUI::OnPrivateBrowsingChange, this);
-  }
-
   elm_ctxpopup_item_append(menu_, "Change page zoom level", NULL,
                            &WindowUI::OnShowZoomPopup, this);
 
@@ -605,20 +597,6 @@ void WindowUI::OnFormProfileChange(void* data, Evas_Object* obj, void*) {
   thiz->CloseMenu();
 }
 
-void WindowUI::OnPrivateBrowsingChange(void* data, Evas_Object* obj, void*) {
-  log_trace("%s", __PRETTY_FUNCTION__);
-  WindowUI* thiz = static_cast<WindowUI*>(data);
-  Ewk_Settings* settings = thiz->window_.GetEwkSettings();
-  if (thiz->window_.IsPrivateBrowsingEnabled()) {
-    ewk_settings_private_browsing_enabled_set(settings, false);
-    thiz->ShowNotification("Private browsing disabled");
-  } else {
-    ewk_settings_private_browsing_enabled_set(settings, true);
-    thiz->ShowNotification("Private browsing enabled");
-  }
-  thiz->CloseMenu();
-}
-
 void WindowUI::Exit(void* data, Evas_Object*, void*) {
   WindowUI* thiz = static_cast<WindowUI*>(data);
   thiz->window_.Exit();
index bf12955..940e38b 100644 (file)
@@ -70,7 +70,6 @@ class WindowUI {
   static void OnAutoFittingDisabled(void* data, Evas_Object*, void*);
   static void OnAutoFillEnabled(void* data, Evas_Object*, void*);
   static void OnAutoFillDisabled(void* data, Evas_Object*, void*);
-  static void OnPrivateBrowsingChange(void* data, Evas_Object*, void*);
 
   static void ClosePopup(void* data, Evas_Object*, void*);
   static void OnShowZoomPopup(void* data, Evas_Object*, void*);