Fixing prevent defects in security-server.

* 60575; Major; Unsigned compared against 0; In function security_server_thread
  in src/server/security-server-main.c
* 52113; Minor; Unchecked return value; In function security_server_thread
  in src/server/security-server-main.c

[Issue#]        SSDWSSP-335
[Bug/Feature]   Prevent detected new defects.
[Cause]         N/A
[Solution]      N/A
[Verification]  Running tests.

Change-Id: Ie74a957585482b3435783c9bcba4dc1e7ce13ee2

diff --git a/src/server/security-server-main.c b/src/server/security-server-main.c
index c417de7..9aa373d 100644 (file)
--- a/src/server/security-server-main.c
+++ b/src/server/security-server-main.c
@@ -1566,7 +1566,7 @@ void *security_server_thread(void *param)
             authorize_SS_API_caller_socket(client_sockfd, API_DATA_SHARE, API_RULE_REQUIRED);
             if (client_has_access(client_sockfd, API_DATA_SHARE)) {
                 SEC_SVR_DBG("%s", "Server: app give access request received");
-                if (basic_hdr.msg_len >= 0 && (size_t)basic_hdr.msg_len >= sizeof(basic_hdr)) {
+                if ((size_t)basic_hdr.msg_len >= sizeof(basic_hdr)) {
                     process_app_get_access_request(client_sockfd,
                         basic_hdr.msg_len - sizeof(basic_hdr));
                 } else {
@@ -1574,9 +1574,13 @@ void *security_server_thread(void *param)
                 }
             } else {
                 SEC_SVR_DBG("%s", "Server: app give access request received (API DENIED - request will not proceed)");
-                send_generic_response(client_sockfd,
+                retval = send_generic_response(client_sockfd,
                     SECURITY_SERVER_MSG_TYPE_GENERIC_RESPONSE,
                     SECURITY_SERVER_RETURN_CODE_ACCESS_DENIED);
+                if (retval != SECURITY_SERVER_SUCCESS)
+                {
+                    SEC_SVR_ERR("ERROR: Cannot send generic response: %d", retval);
+                }
             }
             break;