Fix critical SVACE issue

This patch fixes some critical SVACE issues.

Change-Id: I48296ccf49643421f7210d8d8d0502f31f38705a
Signed-off-by: v-saha <v.saha@samsung.com>

diff --git a/tizen_src/chromium_impl/components/xwalk_extensions/renderer/xwalk_extension_renderer_controller.cc b/tizen_src/chromium_impl/components/xwalk_extensions/renderer/xwalk_extension_renderer_controller.cc
index 71ac916..37c5198 100644 (file)
--- a/tizen_src/chromium_impl/components/xwalk_extensions/renderer/xwalk_extension_renderer_controller.cc
+++ b/tizen_src/chromium_impl/components/xwalk_extensions/renderer/xwalk_extension_renderer_controller.cc
@@ -210,7 +210,7 @@ int32_t XWalkExtensionRendererController::CreateInstance(
     return 0;
   }
 
-  int32_t id;
+  int32_t id = 0;
   browser_->CreateInstance(module->GetName(), &id, &jscode);
   instance_map_[id] = module;
   return id;

diff --git a/tizen_src/chromium_impl/content/browser/media/tizen_renderer_impl.h b/tizen_src/chromium_impl/content/browser/media/tizen_renderer_impl.h
index f11164e..532b99d 100644 (file)
--- a/tizen_src/chromium_impl/content/browser/media/tizen_renderer_impl.h
+++ b/tizen_src/chromium_impl/content/browser/media/tizen_renderer_impl.h
@@ -165,8 +165,8 @@ class CONTENT_EXPORT TizenRendererImpl
   // Identifiers to find the RenderFrameHost that created |this|.
   // NOTE: We store these IDs rather than a RenderFrameHost* because we do not
   // know when the RenderFrameHost is destroyed.
-  int render_process_id_;
-  int routing_id_;
+  int render_process_id_ = 0;
+  int routing_id_ = 0;
 
   // Temporary callback used for Initialize().
   media::PipelineStatusCallback init_cb_;

diff --git a/tizen_src/chromium_impl/content/browser/selection/selection_handle_efl.h b/tizen_src/chromium_impl/content/browser/selection/selection_handle_efl.h
index a886fbf..5fe2795 100644 (file)
--- a/tizen_src/chromium_impl/content/browser/selection/selection_handle_efl.h
+++ b/tizen_src/chromium_impl/content/browser/selection/selection_handle_efl.h
@@ -85,7 +85,7 @@ class SelectionHandleEfl {
   SelectionControllerEfl& controller_;
 
   // Handle object
-  Evas_Object* handle_;
+  Evas_Object* handle_ = nullptr;
 
   // Is pressed
   bool pressed_;

diff --git a/tizen_src/chromium_impl/content/browser/selection/selection_magnifier_efl.h b/tizen_src/chromium_impl/content/browser/selection/selection_magnifier_efl.h
index a693783..50dd9af 100644 (file)
--- a/tizen_src/chromium_impl/content/browser/selection/selection_magnifier_efl.h
+++ b/tizen_src/chromium_impl/content/browser/selection/selection_magnifier_efl.h
@@ -42,16 +42,16 @@ class SelectionMagnifierEfl {
   SelectionControllerEfl* controller_;
 
   // Magnifier
-  Evas_Object* container_;
+  Evas_Object* container_ = nullptr;
 
   // Image displayed on popup
   Evas_Object* content_image_;
 
   // Magnifier Height
-  int height_;
+  int height_ = 0;
 
   // Magnifier width
-  int width_;
+  int width_ = 0;
 
   // Is magnifier showing
   bool shown_;

diff --git a/tizen_src/chromium_impl/content/browser/web_contents/web_contents_impl_efl.cc b/tizen_src/chromium_impl/content/browser/web_contents/web_contents_impl_efl.cc
index b122681..d61070d 100644 (file)
--- a/tizen_src/chromium_impl/content/browser/web_contents/web_contents_impl_efl.cc
+++ b/tizen_src/chromium_impl/content/browser/web_contents/web_contents_impl_efl.cc
@@ -135,9 +135,9 @@ FrameTree* WebContentsImplEfl::CreateNewWindow(
 
   if (efl_delegate_) {
     if (efl_delegate_->WebContentsCreateAsync(std::move(callback))) {
-      DCHECK(new_contents);
-      return &(
-          static_cast<WebContentsImpl*>(new_contents)->GetPrimaryFrameTree());
+      return new_contents ? &(static_cast<WebContentsImpl*>(new_contents)
+                                  ->GetPrimaryFrameTree())
+                          : nullptr;
     } else {
       return nullptr;
     }

diff --git a/tizen_src/ewk/efl_integration/browser/web_view_browser_message_filter.cc b/tizen_src/ewk/efl_integration/browser/web_view_browser_message_filter.cc
index 96a0cd3..139d271 100644 (file)
--- a/tizen_src/ewk/efl_integration/browser/web_view_browser_message_filter.cc
+++ b/tizen_src/ewk/efl_integration/browser/web_view_browser_message_filter.cc
@@ -41,6 +41,8 @@ class WebViewBrowserMessageFilterPrivate
     CHECK(web_view_);
   }
 
+  virtual ~WebViewBrowserMessageFilterPrivate() = default;
+
   void OnReceivedHitTestData(int render_view,
                              const Hit_Test_Params& params) {
     DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

diff --git a/tizen_src/ewk/efl_integration/eweb_context.h b/tizen_src/ewk/efl_integration/eweb_context.h
index dab08bc..eb910a2 100644 (file)
--- a/tizen_src/ewk/efl_integration/eweb_context.h
+++ b/tizen_src/ewk/efl_integration/eweb_context.h
@@ -216,7 +216,7 @@ class EWebContext {
 
  private:
   EWebContext(bool incognito, const std::string& injectedBundlePath);
-  ~EWebContext();
+  virtual ~EWebContext();
   friend class Ewk_Context;
   static void LocalStorageUsageForOrigin(
       const GURL& origin,