Revert "Don't render glyph with FT with fetchMetricsOnly"
authorJiang Jiang <jiang.jiang@nokia.com>
Thu, 1 Mar 2012 13:40:21 +0000 (14:40 +0100)
committerQt by Nokia <qt-info@nokia.com>
Thu, 1 Mar 2012 15:43:37 +0000 (16:43 +0100)
Report https://bugs.webkit.org/show_bug.cgi?id=79561 shows that
this commit will cause significant slow down in text handling
operations. Though the exact reason is unknown we should revert
it first and find out the reason later.

This reverts commit 692064bcfd116c2f3a2b30572e511ee68c6a0531.

Change-Id: I16a56c3093bdfa2119ab6a6e9049ef2925468e29
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
src/gui/text/qfontengine_ft.cpp

index 14e2dba..8880eb7 100644 (file)
@@ -877,7 +877,7 @@ QFontEngineFT::Glyph *QFontEngineFT::loadGlyph(QGlyphSet *set, uint glyph,
     if (err != FT_Err_Ok)
         qWarning("load glyph failed err=%x face=%p, glyph=%d", err, face, glyph);
 
-    if (!set || set->outline_drawing || fetchMetricsOnly)
+    if ((!set || set->outline_drawing) && fetchMetricsOnly)
         return 0;
 
     FT_GlyphSlot slot = face->glyph;