phy: phy-mtk-tphy: fix the phy type setting issue

The PHY type is not set if the index is non zero, prepare type
value according to the index, like as mask value.

Fixes: 39099a443358 ("phy: phy-mtk-tphy: support type switch by pericfg")
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20220914060746.10004-7-chunfeng.yun@mediatek.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

diff --git a/drivers/phy/mediatek/phy-mtk-tphy.c b/drivers/phy/mediatek/phy-mtk-tphy.c
index e0f227a0d3cc35374d98c38d94bc68604e71627f..cc10298bc70d1cdf3acc515b4d5a4ddf13f5e84c 100644 (file)
--- a/drivers/phy/mediatek/phy-mtk-tphy.c
+++ b/drivers/phy/mediatek/phy-mtk-tphy.c
@@ -915,7 +915,7 @@ static int phy_type_syscon_get(struct mtk_phy_instance *instance,
 static int phy_type_set(struct mtk_phy_instance *instance)
 {
        int type;
-       u32 mask;
+       u32 offset;
 
        if (!instance->type_sw)
                return 0;
@@ -938,8 +938,9 @@ static int phy_type_set(struct mtk_phy_instance *instance)
                return 0;
        }
 
-       mask = RG_PHY_SW_TYPE << (instance->type_sw_index * BITS_PER_BYTE);
-       regmap_update_bits(instance->type_sw, instance->type_sw_reg, mask, type);
+       offset = instance->type_sw_index * BITS_PER_BYTE;
+       regmap_update_bits(instance->type_sw, instance->type_sw_reg,
+                          RG_PHY_SW_TYPE << offset, type << offset);
 
        return 0;
 }