ext/pango/gsttextoverlay.c: Added some FIXMEs.

Original commit message from CVS:
* ext/pango/gsttextoverlay.c: (gst_text_overlay_src_event),
(gst_text_overlay_text_event):
Added some FIXMEs.

diff --git a/ChangeLog b/ChangeLog
index 63216f9..10a58a3 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2006-05-30  Wim Taymans  <wim@fluendo.com>
 
+       * ext/pango/gsttextoverlay.c: (gst_text_overlay_src_event),
+       (gst_text_overlay_text_event):
+       Added some FIXMEs.
+
+2006-05-30  Wim Taymans  <wim@fluendo.com>
+
        * gst/adder/gstadder.c: (gst_adder_class_init), (gst_adder_init),
        (gst_adder_request_new_pad), (gst_adder_release_pad):
        * gst/adder/gstadder.h:

diff --git a/ext/pango/gsttextoverlay.c b/ext/pango/gsttextoverlay.c
index 11d0d55..2caa767 100644 (file)
--- a/ext/pango/gsttextoverlay.c
+++ b/ext/pango/gsttextoverlay.c
@@ -698,7 +698,7 @@ gst_text_overlay_src_event (GstPad * pad, GstEvent * event)
 
       GST_DEBUG_OBJECT (overlay, "seek received, driving from here");
 
-      /* Flush downstream */
+      /* Flush downstream, FIXME, only for flushing seek */
       gst_pad_push_event (overlay->srcpad, gst_event_new_flush_start ());
 
       /* Mark ourself as flushing, unblock chains */
@@ -1090,6 +1090,7 @@ gst_text_overlay_text_event (GstPad * pad, GstEvent * event)
     case GST_EVENT_EOS:
       GST_OBJECT_LOCK (overlay);
       /* We use flushing to make sure we return WRONG_STATE */
+      /* FIXME, after EOS a _pad_push() returns _UNEXPECTED */
       overlay->text_flushing = TRUE;
       /* We don't signal anything here because we want to keep the last queued
          buffer until video pad receives EOS or discard the buffer */