i2c: sh7760: fix IRQ error path
authorSergey Shtylyov <s.shtylyov@omprussia.ru>
Sat, 17 Apr 2021 19:05:05 +0000 (22:05 +0300)
committerWolfram Sang <wsa@kernel.org>
Sat, 17 Apr 2021 20:00:58 +0000 (22:00 +0200)
While adding the invalid IRQ check after calling platform_get_irq(),
I managed to overlook that the driver has a complex error path in its
probe() method, thus a simple *return* couldn't be used.  Use a proper
*goto* instead!

Fixes: e5b2e3e74201 ("i2c: sh7760: add IRQ check")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-sh7760.c

index c79c9f5..319d1fa 100644 (file)
@@ -473,7 +473,7 @@ static int sh7760_i2c_probe(struct platform_device *pdev)
 
        ret = platform_get_irq(pdev, 0);
        if (ret < 0)
-               return ret;
+               goto out3;
        id->irq = ret;
 
        id->adap.nr = pdev->id;