ac/rgp: Fix single-bit-bitfield-constant-conversion warning
authorVinson Lee <vlee@freedesktop.org>
Fri, 29 Dec 2023 08:08:24 +0000 (00:08 -0800)
committerEric Engestrom <eric@engestrom.ch>
Wed, 10 Jan 2024 09:27:11 +0000 (09:27 +0000)
../src/amd/common/ac_rgp.c:119:48: warning: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion]
  119 |    header->flags.is_semaphore_queue_timing_etw = 1;
      |                                                ^ ~

Fixes: ed0c8522437 ("radv: add initial SQTT files generation support")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26839>
(cherry picked from commit 568f61787a5cd1a69c799d935c364138ff415a1e)

.pick_status.json
src/amd/common/ac_rgp.c

index 72cbe62..cb865ab 100644 (file)
         "description": "ac/rgp: Fix single-bit-bitfield-constant-conversion warning",
         "nominated": true,
         "nomination_type": 1,
-        "resolution": 0,
+        "resolution": 1,
         "main_sha": null,
         "because_sha": "ed0c852243719c6bac420de50a2f1061250e5b51",
         "notes": null
index 71c61f5..c6a7484 100644 (file)
@@ -79,9 +79,9 @@ struct sqtt_file_chunk_header {
 struct sqtt_file_header_flags {
    union {
       struct {
-         int32_t is_semaphore_queue_timing_etw : 1;
-         int32_t no_queue_semaphore_timestamps : 1;
-         int32_t reserved : 30;
+         uint32_t is_semaphore_queue_timing_etw : 1;
+         uint32_t no_queue_semaphore_timestamps : 1;
+         uint32_t reserved : 30;
       };
 
       uint32_t value;