btrfs: support subpage in btrfs_clone_extent_buffer
authorQu Wenruo <wqu@suse.com>
Tue, 26 Jan 2021 08:33:55 +0000 (16:33 +0800)
committerDavid Sterba <dsterba@suse.com>
Mon, 8 Feb 2021 21:59:02 +0000 (22:59 +0100)
For btrfs_clone_extent_buffer(), it's mostly the same code of
__alloc_dummy_extent_buffer(), except it has extra page copy.

So to make it subpage compatible, we only need to:

- Call set_extent_buffer_uptodate() instead of SetPageUptodate()
  This will set correct uptodate bit for subpage and regular sector size
  cases.

Since we're calling set_extent_buffer_uptodate() which will also set
EXTENT_BUFFER_UPTODATE bit, we don't need to manually set that bit
either.

Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/extent_io.c

index 969de300a95b754ca345d2744035b5525280c0f3..6b27daf62d9436b5473edc5c13ec4540338e294f 100644 (file)
@@ -5163,11 +5163,10 @@ struct extent_buffer *btrfs_clone_extent_buffer(const struct extent_buffer *src)
                        return NULL;
                }
                WARN_ON(PageDirty(p));
-               SetPageUptodate(p);
                new->pages[i] = p;
                copy_page(page_address(p), page_address(src->pages[i]));
        }
-       set_bit(EXTENT_BUFFER_UPTODATE, &new->bflags);
+       set_extent_buffer_uptodate(new);
 
        return new;
 }