gst_clear_*: Remove volatile from arguments

g_clear_pointer is not thread-safe and never was. GLib similarly removed
the volatile from g_clear_object in 2aacef39b1.

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/327

diff --git a/gst/gstminiobject.c b/gst/gstminiobject.c
index 324346c..b55ff58 100644 (file)
--- a/gst/gstminiobject.c
+++ b/gst/gstminiobject.c
@@ -687,7 +687,7 @@ gst_mini_object_unref (GstMiniObject * mini_object)
  **/
 #undef gst_clear_mini_object
 void
-gst_clear_mini_object (volatile GstMiniObject ** object_ptr)
+gst_clear_mini_object (GstMiniObject ** object_ptr)
 {
   g_clear_pointer (object_ptr, gst_mini_object_unref);
 }

diff --git a/gst/gstminiobject.h b/gst/gstminiobject.h
index b9d3314..cfd7562 100644 (file)
--- a/gst/gstminiobject.h
+++ b/gst/gstminiobject.h
@@ -235,7 +235,7 @@ GST_API
 void            gst_mini_object_unref          (GstMiniObject *mini_object);
 
 GST_API
-void        gst_clear_mini_object (volatile GstMiniObject **object_ptr);
+void        gst_clear_mini_object (GstMiniObject **object_ptr);
 #define     gst_clear_mini_object(object_ptr) g_clear_pointer ((object_ptr), gst_mini_object_unref)
 
 GST_API

diff --git a/gst/gstobject.c b/gst/gstobject.c
index f5683a0..3aa20c4 100644 (file)
--- a/gst/gstobject.c
+++ b/gst/gstobject.c
@@ -314,7 +314,7 @@ gst_object_ref_sink (gpointer object)
  **/
 #undef gst_clear_object
 void
-gst_clear_object (volatile GstObject ** object_ptr)
+gst_clear_object (GstObject ** object_ptr)
 {
   g_clear_pointer (object_ptr, gst_object_unref);
 }

diff --git a/gst/gstobject.h b/gst/gstobject.h
index 5fe5a18..bcf6c41 100644 (file)
--- a/gst/gstobject.h
+++ b/gst/gstobject.h
@@ -255,7 +255,7 @@ GST_API
 void           gst_object_unref                (gpointer object);
 
 GST_API
-void        gst_clear_object (volatile GstObject **object_ptr);
+void        gst_clear_object (GstObject **object_ptr);
 #define     gst_clear_object(object_ptr) g_clear_pointer ((object_ptr), gst_object_unref)
 
 GST_API

diff --git a/gst/gststructure.c b/gst/gststructure.c
index dae2b63..b6f3d2e 100644 (file)
--- a/gst/gststructure.c
+++ b/gst/gststructure.c
@@ -413,7 +413,7 @@ gst_structure_free (GstStructure * structure)
  **/
 #undef gst_clear_structure
 void
-gst_clear_structure (volatile GstStructure ** structure_ptr)
+gst_clear_structure (GstStructure ** structure_ptr)
 {
   g_clear_pointer (structure_ptr, gst_structure_free);
 }

diff --git a/gst/gststructure.h b/gst/gststructure.h
index 624b6e6..8e6b972 100644 (file)
--- a/gst/gststructure.h
+++ b/gst/gststructure.h
@@ -134,7 +134,7 @@ GST_API
 void                  gst_structure_free                 (GstStructure        * structure);
 
 GST_API
-void                  gst_clear_structure                (volatile GstStructure **structure_ptr);
+void                  gst_clear_structure                (GstStructure **structure_ptr);
 #define               gst_clear_structure(structure_ptr) g_clear_pointer ((structure_ptr), gst_structure_free)
 
 GST_API