[lldbsuite] Un-xfail tests on Windows that are now passing (pt.4)
authorStella Stamenova <stilis@microsoft.com>
Thu, 20 Dec 2018 01:25:35 +0000 (01:25 +0000)
committerStella Stamenova <stilis@microsoft.com>
Thu, 20 Dec 2018 01:25:35 +0000 (01:25 +0000)
This is a set of tests that were all marked as failing becuse of several different bugs. A couple of the bugs are now resolved as fixed since all the tests that were failing associated with the bug are now passing. It is possible that some of them are false positives, but there's a large number of unexpectedly passing tests on Windows, so I am doing a bulk un-xfail to get the buildbot to green.

llvm-svn: 349713

14 files changed:
lldb/packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py
lldb/packages/Python/lldbsuite/test/expression_command/unwind_expression/TestUnwindExpression.py
lldb/packages/Python/lldbsuite/test/functionalities/conditional_break/TestConditionalBreak.py
lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-cpp/TestDataFormatterCpp.py
lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-smart-array/TestDataFormatterSmartArray.py
lldb/packages/Python/lldbsuite/test/functionalities/disassembly/TestDisassembleBreakpoint.py
lldb/packages/Python/lldbsuite/test/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferior.py
lldb/packages/Python/lldbsuite/test/functionalities/memory/cache/TestMemoryCache.py
lldb/packages/Python/lldbsuite/test/functionalities/memory/find/TestMemoryFind.py
lldb/packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py
lldb/packages/Python/lldbsuite/test/functionalities/thread/exit_during_step/TestExitDuringStep.py
lldb/packages/Python/lldbsuite/test/functionalities/thread/thread_exit/TestThreadExit.py
lldb/packages/Python/lldbsuite/test/lang/c/anonymous/TestAnonymous.py
lldb/packages/Python/lldbsuite/test/lang/c/shared_lib/TestSharedLib.py

index be1d875..c8308c1 100644 (file)
@@ -1,7 +1,4 @@
 from lldbsuite.test import lldbinline
 from lldbsuite.test import decorators
 
-lldbinline.MakeInlineTest(
-    __file__, globals(), [
-        decorators.expectedFailureAll(
-            oslist=["windows"], bugnumber="llvm.org/pr37656")])
+lldbinline.MakeInlineTest(__file__, globals())
index c942427..108de88 100644 (file)
@@ -55,7 +55,6 @@ class UnwindFromExpressionTest(TestBase):
 
 
     @add_test_categories(['pyapi'])
-    @expectedFailureAll(oslist=["windows"])
     def test_unwind_expression(self):
         """Test unwinding from an expression."""
         self.build_and_run_to_bkpt()
index 904fb4c..7b12395 100644 (file)
@@ -34,9 +34,6 @@ class ConditionalBreakTestCase(TestBase):
         self.build()
         self.simulate_conditional_break_by_user()
 
-    @expectedFailureAll(
-        oslist=["windows"],
-        bugnumber="llvm.org/pr26265: args in frames other than #0 are not evaluated correctly")
     def do_conditional_break(self):
         """Exercise some thread and frame APIs to break if c() is called by a()."""
         exe = self.getBuildArtifact("a.out")
index 9749061..4b9de96 100644 (file)
@@ -23,9 +23,6 @@ class CppDataFormatterTestCase(TestBase):
         # Find the line number to break at.
         self.line = line_number('main.cpp', '// Set break point at this line.')
 
-    @expectedFailureAll(
-        oslist=["windows"],
-        bugnumber="llvm.org/pr24462: Data formatters have problems on Windows")
     @skipIf(debug_info="gmodules",
             bugnumber="https://bugs.llvm.org/show_bug.cgi?id=36048")
     def test_with_run_command(self):
index 13b38cb..54e9c34 100644 (file)
@@ -17,9 +17,6 @@ class SmartArrayDataFormatterTestCase(TestBase):
 
     mydir = TestBase.compute_mydir(__file__)
 
-    @expectedFailureAll(
-        oslist=["windows"],
-        bugnumber="llvm.org/pr24462, Data formatters have problems on Windows")
     def test_with_run_command(self):
         """Test data formatter commands."""
         self.build()
index 52f9daf..91b858b 100644 (file)
@@ -18,9 +18,6 @@ class DisassemblyTestCase(TestBase):
     mydir = TestBase.compute_mydir(__file__)
     NO_DEBUG_INFO_TESTCASE = True
 
-    @expectedFailureAll(
-        oslist=["windows"],
-        bugnumber="function names print fully demangled instead of name-only")
     def test(self):
         self.build()
         target, _, _, bkpt = lldbutil.run_to_source_breakpoint(self,
index d8efe65..2cd4d46 100644 (file)
@@ -29,13 +29,11 @@ class CrashingRecursiveInferiorTestCase(TestBase):
         self.recursive_inferior_crashing_registers()
 
     @add_test_categories(['pyapi'])
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     def test_recursive_inferior_crashing_python(self):
         """Test that lldb reliably catches the inferior crashing (Python API)."""
         self.build()
         self.recursive_inferior_crashing_python()
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     def test_recursive_inferior_crashing_expr(self):
         """Test that the lldb expression interpreter can read from the inferior after crashing (command)."""
         self.build()
@@ -47,8 +45,8 @@ class CrashingRecursiveInferiorTestCase(TestBase):
         self.build()
         self.recursive_inferior_crashing_step()
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     @skipIfTargetAndroid()  # debuggerd interferes with this test on Android
+    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     def test_recursive_inferior_crashing_step_after_break(self):
         """Test that lldb functions correctly after stepping through a crash."""
         self.build()
@@ -58,7 +56,6 @@ class CrashingRecursiveInferiorTestCase(TestBase):
     # intended IMHO.
     @skipIfLinux
     @skipIfFreeBSD
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     def test_recursive_inferior_crashing_expr_step_and_expr(self):
         """Test that lldb expressions work before and after stepping after a crash."""
         self.build()
index 6775e16..5150465 100644 (file)
@@ -24,9 +24,6 @@ class MemoryCacheTestCase(TestBase):
         # Find the line number to break inside main().
         self.line = line_number('main.cpp', '// Set break point at this line.')
 
-    # The test is actually flakey on Windows, failing every dozen or so runs, but even with the flakey
-    # decorator it still fails
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr38373")
     def test_memory_cache(self):
         """Test the MemoryCache class with a sequence of 'memory read' and 'memory write' operations."""
         self.build()
index 8e0fbaa..245aaa8 100644 (file)
@@ -24,7 +24,6 @@ class MemoryFindTestCase(TestBase):
         # Find the line number to break inside main().
         self.line = line_number('main.cpp', '// break here')
 
-    @expectedFailureAll(oslist=["windows"])
     def test_memory_find(self):
         """Test the 'memory find' command."""
         self.build()
index b20b738..fa96db0 100644 (file)
@@ -20,7 +20,6 @@ class CrashDuringStepTestCase(TestBase):
         TestBase.setUp(self)
         self.breakpoint = line_number('main.cpp', '// Set breakpoint here')
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     # IO error due to breakpoint at invalid address
     @expectedFailureAll(triple=re.compile('^mips'))
     def test_step_inst_with(self):
index f83b467..0343a88 100644 (file)
@@ -18,9 +18,6 @@ class ExitDuringStepTestCase(TestBase):
     mydir = TestBase.compute_mydir(__file__)
 
     @skipIfFreeBSD  # llvm.org/pr21411: test is hanging
-    # The test is actually flakey on Windows, failing every dozen or so runs, but even with the flakey
-    # decorator it still fails
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr38373")
     def test(self):
         """Test thread exit during step handling."""
         self.build(dictionary=self.getBuildFlags())
@@ -30,9 +27,6 @@ class ExitDuringStepTestCase(TestBase):
             True)
 
     @skipIfFreeBSD  # llvm.org/pr21411: test is hanging
-    # The test is actually flakey on Windows, failing every dozen or so runs, but even with the flakey
-    # decorator it still fails
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr38373")
     def test_step_over(self):
         """Test thread exit during step-over handling."""
         self.build(dictionary=self.getBuildFlags())
@@ -42,9 +36,6 @@ class ExitDuringStepTestCase(TestBase):
             False)
 
     @skipIfFreeBSD  # llvm.org/pr21411: test is hanging
-    # The test is actually flakey on Windows, failing every dozen or so runs, but even with the flakey
-    # decorator it still fails
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr38373")
     def test_step_in(self):
         """Test thread exit during step-in handling."""
         self.build(dictionary=self.getBuildFlags())
index db1d31d..92dbf05 100644 (file)
@@ -26,9 +26,6 @@ class ThreadExitTestCase(TestBase):
         self.break_3 = line_number('main.cpp', '// Set third breakpoint here')
         self.break_4 = line_number('main.cpp', '// Set fourth breakpoint here')
 
-    # The test is actually flakey on Windows, failing every dozen or so runs, but even with the flakey
-    # decorator it still fails
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr38373")
     def test(self):
         """Test thread exit handling."""
         self.build(dictionary=self.getBuildFlags())
index 930a094..e3ae93d 100644 (file)
@@ -70,7 +70,6 @@ class AnonymousTestCase(TestBase):
         self.expect("expression z.y", VARIABLES_DISPLAYED_CORRECTLY,
                     substrs=["(type_y) $", "dummy = 2"])
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21550")
     def test_expr_null(self):
         self.build()
         self.common_setup(self.line2)
index f53a191..d159516 100644 (file)
@@ -35,12 +35,10 @@ class SharedLibTestCase(TestBase):
             "expression GetMeASubFoo(my_foo_ptr)",
             startstr="(sub_foo *) $")
 
-    @expectedFailureAll(oslist=["windows"])
     def test_expr(self):
         """Test that types work when defined in a shared library and forward-declared in the main executable"""
         self.common_test_expr(True)
 
-    @expectedFailureAll(oslist=["windows"])
     def test_expr_no_preload(self):
         """Test that types work when defined in a shared library and forward-declared in the main executable, but with preloading disabled"""
         self.common_test_expr(False)