hwmon: (pmbus/max20730) delete some dead code
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 22 Oct 2020 07:06:59 +0000 (10:06 +0300)
committerGuenter Roeck <linux@roeck-us.net>
Thu, 3 Dec 2020 01:42:22 +0000 (17:42 -0800)
The debugfs_create_dir() function never returns NULL.  Normal users are
not supposed to check the return value so the correct fix is just to
delete this check.

In the case where the debugfs_create_dir() fails, the function returns
NULL.  The other debugfs function check for NULL directory and handle
it.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20201022070659.GA2817762@mwanda
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/pmbus/max20730.c

index be83b98..00fea16 100644 (file)
@@ -328,8 +328,6 @@ static int max20730_init_debugfs(struct i2c_client *client,
                return -ENOENT;
 
        max20730_dir = debugfs_create_dir(client->name, debugfs);
-       if (!max20730_dir)
-               return -ENOENT;
 
        for (i = 0; i < MAX20730_DEBUGFS_NUM_ENTRIES; ++i)
                psu->debugfs_entries[i] = i;