HID: hid-logitech-hidpp: add NULL check on devm_kmemdup() return value
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Fri, 7 Jul 2017 05:12:13 +0000 (00:12 -0500)
committerJiri Kosina <jkosina@suse.cz>
Thu, 20 Jul 2017 13:45:39 +0000 (15:45 +0200)
Check return value from call to devm_kmemdup() in order to prevent a NULL
pointer dereference.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-logitech-hidpp.c

index 41b3946..501e16a 100644 (file)
@@ -2732,6 +2732,9 @@ static int hidpp_initialize_battery(struct hidpp_device *hidpp)
                                     hidpp_battery_props,
                                     sizeof(hidpp_battery_props),
                                     GFP_KERNEL);
+       if (!battery_props)
+               return -ENOMEM;
+
        num_battery_props = ARRAY_SIZE(hidpp_battery_props) - 2;
 
        if (hidpp->capabilities & HIDPP_CAPABILITY_BATTERY_MILEAGE)