Revert "Fix Text Anchor don't work properly"
authorANZ1217 <chihun.jeong@samsung.com>
Fri, 12 Jan 2024 03:38:17 +0000 (12:38 +0900)
committerANZ1217 <chihun.jeong@samsung.com>
Fri, 12 Jan 2024 03:38:17 +0000 (12:38 +0900)
This reverts commit 1d65ac99b64735697e4ba7db7a5a5ca8d8dba677.

dali-toolkit/internal/controls/text-controls/text-label-impl.cpp
dali-toolkit/internal/text/controller/text-controller-event-handler.cpp
dali-toolkit/internal/text/controller/text-controller.cpp
dali-toolkit/internal/text/controller/text-controller.h
dali-toolkit/internal/text/text-model.h

index b787366..fbebd86 100644 (file)
@@ -1138,8 +1138,6 @@ void TextLabel::OnRelayout(const Vector2& size, RelayoutContainer& container)
     visualTransformOffset.x = roundf(padding.start + alignmentOffset.x);
     visualTransformOffset.y = roundf(padding.top + alignmentOffset.y);
 
-    mController->SetVisualTransformOffset(visualTransformOffset);
-
     Property::Map visualTransform;
     visualTransform.Add(Toolkit::Visual::Transform::Property::SIZE, layoutSize)
       .Add(Toolkit::Visual::Transform::Property::SIZE_POLICY, Vector2(Toolkit::Visual::Transform::Policy::ABSOLUTE, Toolkit::Visual::Transform::Policy::ABSOLUTE))
index 9708844..dddb7da 100644 (file)
@@ -377,19 +377,16 @@ void Controller::EventHandler::AnchorEvent(Controller& controller, float x, floa
   CharacterIndex cursorPosition = 0u;
 
   // Convert from control's coords to text's coords.
-
   const float xPosition = x - controller.mImpl->mModel->mScrollPosition.x;
   const float yPosition = y - controller.mImpl->mModel->mScrollPosition.y;
 
-  Vector2 visualTransformOffset = controller.mImpl->mModel->mVisualTransformOffset;
-
   // Whether to touch point hits on a glyph.
   bool matchedCharacter = false;
   cursorPosition        = Text::GetClosestCursorIndex(controller.mImpl->mModel->mVisualModel,
                                                controller.mImpl->mModel->mLogicalModel,
                                                controller.mImpl->mMetrics,
                                                xPosition,
-                                               yPosition - visualTransformOffset.y,
+                                               yPosition,
                                                CharacterHitTest::TAP,
                                                matchedCharacter);
 
index d4082fb..399e871 100644 (file)
@@ -1416,11 +1416,6 @@ const float Controller::GetCharacterSpacing() const
   return mImpl->mModel->mVisualModel->GetCharacterSpacing();
 }
 
-void Controller::SetVisualTransformOffset(Vector2 offset)
-{
-  mImpl->mModel->mVisualTransformOffset = offset;
-}
-
 Controller::UpdateTextType Controller::Relayout(const Size& size, Dali::LayoutDirection::Type layoutDirection)
 {
   return Relayouter::Relayout(*this, size, layoutDirection);
index b6f0aff..38b1e98 100644 (file)
@@ -1574,13 +1574,6 @@ public: // Default style & Input style
    */
   const float GetCharacterSpacing() const;
 
-  /**
-   * @brief Sets the visual transform offset.
-   *
-   * @param[in] offset The offset.
-   */
-  void SetVisualTransformOffset(Vector2 offset);
-
 public: // Queries & retrieves.
   /**
    * @brief Return the layout engine.
index 92a514a..a3a42a2 100644 (file)
@@ -380,7 +380,6 @@ public:
   bool                                   mIgnoreSpacesAfterText : 1; ///< Whether ignoring spaces after text or not. Default is true.
   DevelText::MatchLayoutDirection        mMatchLayoutDirection;      ///< Whether to match text alignment with layout direction or not.
   DevelText::EllipsisPosition::Type      mEllipsisPosition;          ///< Where is the location the text elide
-  Vector2                                mVisualTransformOffset;     ///< The offset of the layout based on the controller due to alignment.
 };
 
 } // namespace Text